Re: [PATCH v4 5/5] remote: announce removal of "branches/" and "remotes/"

[Patrick Steinhardt <ps@pks.im>]

On Tue, Feb 25, 2025 at 03:45:42PM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > On Fri, Feb 21, 2025 at 10:30:30AM -0800, Junio C Hamano wrote:
> >> Jakub Wilk <jwilk@jwilk.net> writes:
> >> 
> >> > * Patrick Steinhardt <ps@pks.im>, 2025-01-22 12:31:
> >> >>+As our documentation mentions, these directories are not to be found in modern
> >> >>+repositories at all and most users aren't even aware of these mechanisms. They
> >> >
> >> > This isn't accurate. The "branches/" directory used to be part of the
> >> > default template until very recently, so it's found all over the place
> >> > (although most likely empty).
> >> >
> >> > I'd say: "... these directories are unlikely to be used in modern
> >> > repositories and ..."
> >> 
> >> That's a very careful reading.  Thanks for pointing out the
> >> distinction between being found and being used.
> >
> > Indeed. Do you maybe want to send a patch for this? Otherwise I can
> > handle it for you.
> >
> > Thanks!
> >
> > Patrick

Ah, I didn't mean you, Junio, but Jakub. But anyway, thanks for sending
the patch!

> --- >8 ---
> Subject: BreakingChanges: clarify branches/ and remotes/
> 
> As we have created an empty .git/branches/ hierarchy until fairly
> recently, these directories may be found in modern repositories, but
> it is highly unlikely that they are being used.
> 
> Reported-by: Jakub Wilk <jwilk@jwilk.net>
> Acked-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  Documentation/BreakingChanges.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git c/Documentation/BreakingChanges.txt w/Documentation/BreakingChanges.txt
> index 7c388e56c8..042709a461 100644
> --- c/Documentation/BreakingChanges.txt
> +++ w/Documentation/BreakingChanges.txt
> @@ -169,8 +169,8 @@ started to migrate away from ".git/remotes/" in favor of config-based remotes,
>  and we have marked the directory as legacy in 3d3d282146 (Documentation:
>  Grammar correction, wording fixes and cleanup, 2011-08-23)
>  +
> -As our documentation mentions, these directories are not to be found in modern
> -repositories at all and most users aren't even aware of these mechanisms. They
> +As our documentation mentions, these directories are unlikely to be used in
> +modern repositories and most users aren't even aware of these mechanisms. They
>  have been deprecated for almost 20 years and 14 years respectively, and we are
>  not aware of any active users that have complained about this deprecation.
>  Furthermore, the ".git/branches/" directory is nowadays misleadingly named and

The change looks great to me, thanks!

Patrick