public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: "Matěj Cepl" <mcepl@cepl.eu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] doc(send-email): use correct name of the --signed-off-by-cc in git send-email doc
Date: Tue, 18 Feb 2025 12:22:05 +0100	[thread overview]
Message-ID: <Z7RtXXsDRxuEqCgC@pks.im> (raw)
In-Reply-To: <20250218085913.1381537-1-mcepl@cepl.eu>

On Tue, Feb 18, 2025 at 09:58:38AM +0100, Matěj Cepl wrote:
> I don’t think there is an option --signed-off-cc (without -by)
> for git send-email.
> 
> Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
> ---
> Rebase on the top of the current master (Whoops!) and improve the commit message.

It's better, but still not quite there:

  - The subject now uses `doc(send-email)`, which is an idiom we don't
    use over here.

  - The commit message still doesn't use imperative mood.

I know, we're quite pedantic about commit messages over here, but please
bear with us :) How about this instead:

    docs: fix misspelled `--no-signed-off-by-cc` in git-send-email(1)

    In git-send-email(1) we reference the `--no-signed-off-cc` command
    line argument. This argument does not exist and never has existed,
    but it is an obvious misspelling of `--no-signed-off-by-cc`.

    Fix the misspelled argument.

    Signed-off-by: ...

It would also be great if you send future revisions of a patch series in
the same thread. You can do so via `--in-reply-to`, where the parameter
is the message ID of the first message of the first version of your
patch series.

Thanks!

Patrick

  reply	other threads:[~2025-02-18 11:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18  8:58 [PATCH v2] doc(send-email): use correct name of the --signed-off-by-cc in git send-email doc Matěj Cepl
2025-02-18 11:22 ` Patrick Steinhardt [this message]
2025-02-18 15:21   ` Matěj Cepl
2026-02-05 16:24 ` [PATCH v3] doc: send-email: correct --no-signed-off-by-cc misspelling kristofferhaugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7RtXXsDRxuEqCgC@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=mcepl@cepl.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox