From: Patrick Steinhardt <ps@pks.im>
To: Phillip Wood via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] meson: fix building technical and howto docs
Date: Mon, 3 Mar 2025 11:17:39 +0100 [thread overview]
Message-ID: <Z8WBw1L50zVmjGIs@pks.im> (raw)
In-Reply-To: <pull.1870.git.1740931350451.gitgitgadget@gmail.com>
On Sun, Mar 02, 2025 at 04:02:30PM +0000, Phillip Wood via GitGitGadget wrote:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> When our asciidoc files were renamed from "*.txt" to "*.adoc" in
> 1f010d6bdf7 (doc: use .adoc extension for AsciiDoc files, 2025-01-20)
> the "meson.build" file in "Documentation" was updated but the
> "meson.build" files in the "technical" and "howto" subdirectories were
> not. This causes the meson build to fail when configured with
> -Ddocs=html. Fix this by updating the relevant "meson.build" files.
Good catch, thanks! I wonder: do we maybe also want to start building
documentation with Meson so that we would catch issues like this
earlier?
In any case, I'm happy to defer that to a later point and for now only
land the fix.
Patrick
next prev parent reply other threads:[~2025-03-03 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 16:02 [PATCH] meson: fix building technical and howto docs Phillip Wood via GitGitGadget
2025-03-03 10:17 ` Patrick Steinhardt [this message]
2025-03-03 14:32 ` Phillip Wood
2025-03-03 16:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8WBw1L50zVmjGIs@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).