From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org, Steffen Nurpmeso <steffen@sdaoden.eu>
Subject: Re: meson build: datadir missing?
Date: Tue, 4 Mar 2025 08:08:01 +0100 [thread overview]
Message-ID: <Z8am0ZmkJ7QD13_g@pks.im> (raw)
In-Reply-To: <20250303203320.lP10PHC5@steffen%sdaoden.eu>
On Mon, Mar 03, 2025 at 09:33:20PM +0100, Steffen Nurpmeso wrote:
> Hello again after a long time.
>
> I opened
>
> https://git.crux.nu/ports/opt/issues/18
>
> at my linux distro ([ports/opt] git: creates incomplete repos),
> because hook etc directories were missing:
>
> warning: templates not found in /share/git-core/templates
Okay.
> hi. thanks, i see now (after looking around). it is a fallout of switching to meson, that build system seems incomplete
>
> master:meson.build: '-DDEFAULT_GIT_TEMPLATE_DIR="' + get_option('datadir') / 'git-core/templates' + '"',
>
> but that "datadir" does not happen to be set at all it seems; is this known upstream? (Hamano does not like me either, so i will not do that..)
"datadir" is set, as it is a default option provided by Meson itself,
and can be configured with `meson setup --datadir`. I've also
double-checked the logic how we set the template directory path, but it
does seem to be correct: our Makefile sets up a path relative to the
prefix, and we do the exact same here. Double-checking on my machine
also confirmed that this works as expected:
$ meson setup /tmp/build --prefix=/tmp/prefix
$ meson install -C /tmp/build
$ touch /tmp/prefix/share/git-core/templates/foobar
$ /tmp/prefix/bin/git git init /tmp/repo
$ ls /tmp/repo/.git
config description foobar HEAD hooks info objects refs reftable
So I had a closer look at the recipe that Crux uses for building Git
[1]. As it turns out, the issue isn't the prefix or datadir, but that
Crux enables `-Druntime_prefix=true`:
$ meson setup /tmp/build --prefix=/tmp/prefix -Druntime_prefix=true
$ meson install -C /tmp/build
$ /tmp/prefix/bin/git git init /tmp/repo
warning: templates not found in /share/git-core/templates
This is a bug that has already been fixed via bd262d07b65 (meson: fix
exec path with enabled runtime prefix, 2025-02-26). I'd recommend to
backport this fix or disable the runtime prefix.
> Only wondering why this happens at all, and is not covered by its tests, really.
Things like this are somewhat hard to test for as they require a proper
installation.
[1]: https://git.crux.nu/ports/opt/src/branch/3.7/git/Pkgfile
Patrick
next prev parent reply other threads:[~2025-03-04 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 20:33 meson build: datadir missing? Steffen Nurpmeso
2025-03-04 7:08 ` Patrick Steinhardt [this message]
2025-03-04 18:16 ` Steffen Nurpmeso
2025-03-05 7:19 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8am0ZmkJ7QD13_g@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=steffen@sdaoden.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).