Re: [PATCH 04/12] environment: move access to "core.bigFileThreshold" into repo settings

[Patrick Steinhardt <ps@pks.im>]

On Tue, Mar 04, 2025 at 01:32:53PM -0600, Justin Tobler wrote:
> On 25/03/03 09:47AM, Patrick Steinhardt wrote:
> > diff --git a/t/t1050-large.sh b/t/t1050-large.sh
> > index c71932b0242..5be273611ad 100755
> > --- a/t/t1050-large.sh
> > +++ b/t/t1050-large.sh
> > @@ -6,7 +6,8 @@ test_description='adding and checking out large blobs'
> >  . ./test-lib.sh
> >  
> >  test_expect_success 'core.bigFileThreshold must be non-negative' '
> > -	test_must_fail git -c core.bigFileThreshold=-1 rev-parse >out 2>err &&
> > +	: >input &&
> > +	test_must_fail git -c core.bigFileThreshold=-1 hash-object input >out 2>err &&
> >  	grep "bad numeric config value" err &&
> >  	test_must_be_empty out
> >  '
> 
> I assume the test is updated because core.bigFileThreshold is now only
> computed as-needed. Is that correct?

Exactly. git-rev-parse(1) doesn't use the variable at all, so it won't
hit the code anymore.

> It may be worth mentioning in the commit message.

Will do.

Patrick