git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
	git@vger.kernel.org, Igor Todorovski <itodorov@ca.ibm.com>,
	Bence Ferdinandy <bence@ferdinandy.com>
Subject: Re: [PATCH 0/2] limiting followRemoteHEAD being used
Date: Tue, 18 Mar 2025 19:02:51 -0400	[thread overview]
Message-ID: <Z9n7myvpnDOWFWqt@nand.local> (raw)
In-Reply-To: <xmqqmsdi2lm6.fsf@gitster.g>

On Tue, Mar 18, 2025 at 12:18:41PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > There is one interesting case we haven't discussed. What should:
> >
> >   git fetch origin HEAD
> >
> > do with respect to refs/remotes/origin/HEAD? Right now it does nothing
> > (at least with the v2 protocol). We ask about HEAD, but since we didn't
> > fetch the matching ref, set_head() won't accept it. And after my
> > patches, we would not even try to call set_head() at all (since we are
> > not using the full refspecs).
> >
> > But it's also something I could see somebody doing to try to update
> > refs/remotes/origin/HEAD. I've left it alone for now, since my series
> > does not change the behavior either way. But it might be something we
> > could do on top (though it gets funny, because with the code as it is
> > now, we'd have to ask for all of refs/heads/ to see the pointed-to
> > branch advertised).
>
> With v2 protocol, we have direct knowledge of where their HEAD
> points at (when we ask for it), so we shouldn't even have to know
> about what they have under "refs/heads/".  I do not think it is
> within our contract that we'd somehow make sure that HEAD in a
> remote-tracking hierarchy is not dangling, or something.
>
> In any case, I agree that it is sensible to leave it out of these
> changes for now.

Ditto, and I am quite happy with the end-state of this series.

> Thanks.

Thanks,
Taylor

  reply	other threads:[~2025-03-18 23:02 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  3:49 Tags are no longer fetched when fetching specific commit Igor Todorovski
2025-02-13 22:38 ` Taylor Blau
2025-02-14 13:53   ` Bence Ferdinandy
2025-02-14 18:35   ` Junio C Hamano
2025-02-21  7:25     ` Jeff King
2025-03-07 23:27 ` [PATCH] fetch: fix following tags when fetching specific OID Taylor Blau
2025-03-07 23:32   ` Taylor Blau
2025-03-08  0:10   ` Junio C Hamano
2025-03-08  3:23   ` Bence Ferdinandy
2025-03-09  3:01   ` [PATCH 0/9] fetch: further ref-prefix cleanups and optimizations Jeff King
2025-03-09  3:01     ` [PATCH 1/9] t5702: fix typo in test name Jeff King
2025-03-12 21:30       ` Taylor Blau
2025-03-13  5:37         ` Jeff King
2025-03-09  3:01     ` [PATCH 2/9] t5516: prefer "oid" to "sha1" in some test titles Jeff King
2025-03-09  3:02     ` [PATCH 3/9] t5516: drop NEEDSWORK about v2 reachability behavior Jeff King
2025-03-12 21:30       ` Taylor Blau
2025-03-09  3:02     ` [PATCH 4/9] t5516: beef up exact-oid ref prefixes test Jeff King
2025-03-09  3:07     ` [PATCH 5/9] refspec_ref_prefixes(): clean up refspec_item logic Jeff King
2025-03-12 21:38       ` Taylor Blau
2025-03-13  5:41         ` Jeff King
2025-03-13 13:26           ` Junio C Hamano
2025-03-17 22:24             ` [PATCH 0/4] refspec: treat 'fetch' as a Boolean value Taylor Blau
2025-03-17 22:24               ` [PATCH 1/4] " Taylor Blau
2025-03-18  0:24                 ` Jeff King
2025-03-18  0:26                   ` Jeff King
2025-03-18 22:44                   ` Taylor Blau
2025-03-17 22:24               ` [PATCH 2/4] refspec: replace `refspec_init()` with fetch/push variants Taylor Blau
2025-03-17 22:24               ` [PATCH 3/4] refspec: remove refspec_item_init_or_die() Taylor Blau
2025-03-17 22:24               ` [PATCH 4/4] refspec: replace `refspec_item_init()` with fetch/push variants Taylor Blau
2025-03-17 23:26               ` [PATCH 0/4] refspec: treat 'fetch' as a Boolean value Junio C Hamano
2025-03-18 22:40                 ` Taylor Blau
2025-03-18 22:50             ` [PATCH v2 " Taylor Blau
2025-03-18 22:50               ` [PATCH v2 1/4] " Taylor Blau
2025-03-18 22:50               ` [PATCH v2 2/4] refspec: replace `refspec_init()` with fetch/push variants Taylor Blau
2025-03-18 22:50               ` [PATCH v2 3/4] refspec: remove refspec_item_init_or_die() Taylor Blau
2025-03-18 22:50               ` [PATCH v2 4/4] refspec: replace `refspec_item_init()` with fetch/push variants Taylor Blau
2025-03-19 15:31               ` [PATCH v2 0/4] refspec: treat 'fetch' as a Boolean value Elijah Newren
2025-03-17 22:00           ` [PATCH 5/9] refspec_ref_prefixes(): clean up refspec_item logic Taylor Blau
2025-03-17 23:25             ` Junio C Hamano
2025-03-18 22:47               ` Taylor Blau
2025-03-09  3:08     ` [PATCH 6/9] fetch: ask server to advertise HEAD for config-less fetch Jeff King
2025-03-12 21:43       ` Taylor Blau
2025-03-13  5:46         ` Jeff King
2025-03-13 12:26           ` Junio C Hamano
2025-03-17 22:23             ` Taylor Blau
2025-03-09  3:10     ` [PATCH 7/9] fetch: stop protecting additions to ref-prefix list Jeff King
2025-03-12 21:45       ` Taylor Blau
2025-03-09  3:20     ` [PATCH 8/9] fetch: avoid ls-refs only to ask for HEAD symref update Jeff King
2025-03-13 15:53       ` Junio C Hamano
2025-03-17 18:06         ` Jeff King
2025-03-17 19:01           ` Junio C Hamano
2025-03-18  5:39             ` [PATCH 0/2] limiting followRemoteHEAD being used Jeff King
2025-03-18  5:40               ` [PATCH 1/2] fetch: only respect followRemoteHEAD with configured refspecs Jeff King
2025-03-18 23:02                 ` Taylor Blau
2025-03-18  5:41               ` [PATCH 2/2] fetch: don't ask for remote HEAD if followRemoteHEAD is "never" Jeff King
2025-03-18 19:18               ` [PATCH 0/2] limiting followRemoteHEAD being used Junio C Hamano
2025-03-18 23:02                 ` Taylor Blau [this message]
2025-03-09  3:21     ` [PATCH 9/9] fetch: use ref prefix list to skip ls-refs Jeff King
2025-03-12 21:29     ` [PATCH 0/9] fetch: further ref-prefix cleanups and optimizations Taylor Blau
2025-03-12 21:49       ` Taylor Blau
2025-03-13  5:50         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9n7myvpnDOWFWqt@nand.local \
    --to=me@ttaylorr.com \
    --cc=bence@ferdinandy.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=itodorov@ca.ibm.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).