From: Patrick Steinhardt <ps@pks.im>
To: Jensen Huang <hmz007@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] index-pack, unpack-objects: restore missing ->init_fn
Date: Wed, 19 Mar 2025 10:32:34 +0100 [thread overview]
Message-ID: <Z9qPMvclpdEIjQ3l@pks.im> (raw)
In-Reply-To: <20250318111616.113941-1-hmz007@gmail.com>
On Tue, Mar 18, 2025 at 07:16:10PM +0800, Jensen Huang wrote:
> Commit 0578f1e66a ("global: adapt callers to use generic hash context helpers")
> accidentally removed `->init_fn`, which is required for OpenSSL 3+ SHA1.
>
> This fixes the following error on fetch:
> fatal: fetch-pack: invalid index-pack output
The change makes sense indeed. I do wonder though: can we maybe improve
`git_hash_clone()` so that it is not required to initialize the context
beforehand?
Thanks!
Patrick
next prev parent reply other threads:[~2025-03-19 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 11:16 [PATCH] index-pack, unpack-objects: restore missing ->init_fn Jensen Huang
2025-03-19 9:32 ` Patrick Steinhardt [this message]
2025-03-19 11:53 ` gtXfined H.
2025-03-19 13:12 ` Patrick Steinhardt
2025-03-21 6:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9qPMvclpdEIjQ3l@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hmz007@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox