From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alejandro Colomar <alx.manpages@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Better suggestions when git-am(1) fails
Date: Mon, 13 Mar 2023 12:37:54 -0400 [thread overview]
Message-ID: <ZA9RYncZaqoA0mCw@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqh6us7epk.fsf@gitster.g>
On Fri, Mar 10, 2023 at 08:28:55AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > 1. I feel like "-p1" was pretty standard even before Git. You'd
> > extract two copies of the tarball, one into "foo-1.2.3" and one
> > into "foo-1.2.3.orig", and then "diff -Nru" between them to send a
> > patch.
>
> I would too, but then we wouldn't have accepted the request to add
> .noprefix configuration; I do not recall where it came from.
I always thought it was an aesthetic thing for humans viewing diffs (and
likewise mnemonicprefix). The original thread doesn't give much
motivation, though:
https://lore.kernel.org/git/1272852221-14927-1-git-send-email-eli@cloudera.com/
That is not really important as what the option has grown to be used
for, of course, but it's another data point (or lack thereof in this
case).
-Peff
next prev parent reply other threads:[~2023-03-13 16:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 20:15 Better suggestions when git-am(1) fails Alejandro Colomar
2023-03-09 3:17 ` Jeff King
2023-03-09 6:06 ` Jeff King
2023-03-09 6:07 ` [PATCH 1/5] diff: factor out src/dst prefix setup Jeff King
2023-03-09 10:50 ` Alejandro Colomar
2023-03-09 6:07 ` [PATCH 2/5] t4013: add tests for diff prefix options Jeff King
2023-03-09 6:09 ` [PATCH 3/5] diff: add --default-prefix option Jeff King
2023-03-09 10:51 ` Alejandro Colomar
2023-03-09 16:31 ` Junio C Hamano
2023-03-10 9:44 ` Jeff King
2023-03-10 17:04 ` Junio C Hamano
2023-03-13 16:43 ` Jeff King
2023-03-13 17:17 ` Junio C Hamano
2023-03-13 17:31 ` Junio C Hamano
2023-03-13 19:54 ` Jeff King
2023-03-09 6:11 ` [PATCH 4/5] format-patch: do not respect diff.noprefix Jeff King
2023-03-09 10:53 ` Alejandro Colomar
2023-03-09 16:41 ` Junio C Hamano
2023-03-10 9:49 ` Jeff King
2023-03-09 6:12 ` [PATCH 5/5] format-patch: add format.noprefix option Jeff King
2023-03-09 17:00 ` Junio C Hamano
2023-03-10 9:51 ` Jeff King
2023-03-09 10:58 ` Better suggestions when git-am(1) fails Alejandro Colomar
2023-03-09 21:53 ` Junio C Hamano
2023-03-10 9:54 ` Jeff King
2023-03-09 16:22 ` Junio C Hamano
2023-03-10 9:39 ` Jeff King
2023-03-10 16:28 ` Junio C Hamano
2023-03-13 16:37 ` Jeff King [this message]
2023-03-13 17:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA9RYncZaqoA0mCw@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=alx.manpages@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).