From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Glen Choo via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Glen Choo <chooglen@google.com>
Subject: Re: [PATCH] clone: error specifically with --local and symlinked objects
Date: Thu, 6 Apr 2023 17:27:20 -0400 [thread overview]
Message-ID: <ZC85ODogr79t0ZXZ@nand.local> (raw)
In-Reply-To: <xmqq7curxk22.fsf@gitster.g>
On Tue, Apr 04, 2023 at 05:13:41PM -0700, Junio C Hamano wrote:
> * if lstat() succeeds, but the path is *not* a directory; errno is
> explicitly set to ENOTDIR. Unfortunately, if lstat(2) failed
> with ENOTDIR (e.g. dir_iterator_begin() gets called with a path
> whose leading component is not a directory), the caller will also
> see ENOTDIR, but the distinction may not matter in practice. I
> haven't thought things through.
Yeah. The real tragedy here is that there's no way to signal that a file
*is* a symbolic link and represent that as an error code in errno.
So I think the best that we can do here is to continue to report
ENOTDIR, and have the caller figure out what to do with it.
Thanks,
Taylor
next prev parent reply other threads:[~2023-04-06 21:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 23:48 [PATCH] clone: error specifically with --local and symlinked objects Glen Choo via GitGitGadget
2023-04-05 0:13 ` Junio C Hamano
2023-04-05 16:48 ` Glen Choo
2023-04-05 19:20 ` Junio C Hamano
2023-04-06 21:35 ` Taylor Blau
2023-04-06 21:55 ` Glen Choo
2023-04-06 21:27 ` Taylor Blau [this message]
2023-04-10 22:18 ` [PATCH v2] " Glen Choo via GitGitGadget
2023-04-10 22:27 ` Junio C Hamano
2023-04-10 23:16 ` Taylor Blau
2023-04-11 1:58 ` Taylor Blau
2023-04-11 17:08 ` [PATCH v3] " Glen Choo via GitGitGadget
2023-04-11 17:13 ` Junio C Hamano
2023-04-11 18:38 ` Glen Choo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC85ODogr79t0ZXZ@nand.local \
--to=me@ttaylorr.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).