From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] dropping "verbose" test helper function
Date: Mon, 8 May 2023 18:26:29 -0400 [thread overview]
Message-ID: <ZFl3FSt2a59G/X7m@nand.local> (raw)
In-Reply-To: <20230508185953.GA2108869@coredump.intra.peff.net>
On Mon, May 08, 2023 at 02:59:53PM -0400, Jeff King wrote:
> I happened across an instance of the "verbose" helper function in a
> test recently. I think it's clear we prefer the "-x" tracing to it these
> days, and we've been slowly removing instances. This series gets rid of
> the last few.
>
> The actual change (and rationale) is in patch 3. Patch 1 just fixes pipe
> problems on lines we'll be touching patch 3, and patch 2 is a cute
> optimization enabled by patch 1. I don't think any of it should be very
> controversial, but it can all be split up if need be.
>
> [1/3]: t7001: avoid git on upstream of pipe
> [2/3]: t7001: use "ls-files --format" instead of "cut"
> [3/3]: t: drop "verbose" helper function
All look good to me, I'd be happy to see this get picked up.
Thanks,
Taylor
prev parent reply other threads:[~2023-05-08 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 18:59 [PATCH 0/3] dropping "verbose" test helper function Jeff King
2023-05-08 19:01 ` [PATCH 1/3] t7001: avoid git on upstream of pipe Jeff King
2023-05-08 19:01 ` [PATCH 2/3] t7001: use "ls-files --format" instead of "cut" Jeff King
2023-05-08 19:04 ` [PATCH 3/3] t: drop "verbose" helper function Jeff King
2023-05-08 22:26 ` Taylor Blau
2023-05-08 22:26 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFl3FSt2a59G/X7m@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).