From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Elijah Newren <newren@gmail.com>,
Calvin Wan <calvinwan@google.com>
Subject: Re: [PATCH 2/3] var: add attributes files locations
Date: Thu, 22 Jun 2023 21:30:06 +0000 [thread overview]
Message-ID: <ZJS9XhlIs4jGBjHE@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <CAPig+cQ=B7M6nPYx-+gqtsJeSuiqKeQhCfiWmyfjiGXsVnFbTw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On 2023-06-22 at 21:18:46, Eric Sunshine wrote:
> The reference to $(pwd) is unnecessary, thus potentially confusing. Simpler:
>
> TRASHDIR="$(test-tool path-utils normalize_path_copy .)" &&
Maybe. I spent a lot of time fighting with Windows and its path
handling here (as much as writing the initial series). If that's
possible and produces an acceptable result there, I can consider it for
v2.
--
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2023-06-22 21:30 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 19:50 [PATCH 0/3] Additional variables for git var brian m. carlson
2023-06-22 19:50 ` [PATCH 1/3] var: add support for listing the shell brian m. carlson
2023-06-22 20:42 ` Eric Sunshine
2023-06-22 21:05 ` Junio C Hamano
2023-06-22 21:13 ` Eric Sunshine
2023-06-22 21:25 ` brian m. carlson
2023-06-22 21:41 ` Junio C Hamano
2023-06-22 21:20 ` brian m. carlson
2023-06-22 19:50 ` [PATCH 2/3] var: add attributes files locations brian m. carlson
2023-06-22 20:19 ` Derrick Stolee
2023-06-22 21:17 ` brian m. carlson
2023-06-22 21:37 ` Junio C Hamano
2023-06-22 21:17 ` Junio C Hamano
2023-06-22 21:18 ` Eric Sunshine
2023-06-22 21:30 ` brian m. carlson [this message]
2023-06-22 21:21 ` Eric Sunshine
2023-06-22 19:50 ` [PATCH 3/3] var: add config file locations brian m. carlson
2023-06-22 21:35 ` Eric Sunshine
2023-06-26 19:00 ` [PATCH v2 0/7] Additional variables for git var brian m. carlson
2023-06-26 19:00 ` [PATCH v2 1/7] t: add a function to check executable bit brian m. carlson
2023-06-26 19:00 ` [PATCH v2 2/7] var: add support for listing the shell brian m. carlson
2023-06-26 19:00 ` [PATCH v2 3/7] var: format variable structure with C99 initializers brian m. carlson
2023-06-26 19:00 ` [PATCH v2 4/7] var: adjust memory allocation for strings brian m. carlson
2023-06-26 19:56 ` Junio C Hamano
2023-06-26 19:00 ` [PATCH v2 5/7] attr: expose and rename accessor functions brian m. carlson
2023-06-26 19:58 ` Junio C Hamano
2023-06-26 19:00 ` [PATCH v2 6/7] var: add attributes files locations brian m. carlson
2023-06-27 7:05 ` Jeff King
2023-06-27 16:12 ` brian m. carlson
2023-06-27 17:56 ` Junio C Hamano
2023-06-27 20:16 ` Jeff King
2023-06-26 19:00 ` [PATCH v2 7/7] var: add config file locations brian m. carlson
2023-06-26 20:02 ` Junio C Hamano
2023-06-27 16:18 ` [PATCH v3 0/8] Additional variables for git var brian m. carlson
2023-06-27 16:18 ` [PATCH v3 1/8] var: mark unused parameters in git_var callbacks brian m. carlson
2023-06-27 16:18 ` [PATCH v3 2/8] t: add a function to check executable bit brian m. carlson
2023-06-27 16:18 ` [PATCH v3 3/8] var: add support for listing the shell brian m. carlson
2023-06-27 16:18 ` [PATCH v3 4/8] var: format variable structure with C99 initializers brian m. carlson
2023-06-27 16:18 ` [PATCH v3 5/8] var: adjust memory allocation for strings brian m. carlson
2023-06-27 16:19 ` [PATCH v3 6/8] attr: expose and rename accessor functions brian m. carlson
2023-06-27 16:19 ` [PATCH v3 7/8] var: add attributes files locations brian m. carlson
2023-06-27 16:19 ` [PATCH v3 8/8] var: add config file locations brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJS9XhlIs4jGBjHE@tapette.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=calvinwan@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).