git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: uxecw <uxecw@student.kit.edu>
Cc: git@vger.kernel.org
Subject: Re: Bug Report - Git does not require a space between shorthand flags and the commit-message
Date: Fri, 14 Jul 2023 00:48:26 +0000	[thread overview]
Message-ID: <ZLCbWn2qXZhmf8XD@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <fcdf19b3-269b-aa9f-38c2-d0f775524a89@student.kit.edu>

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

On 2023-07-13 at 13:04:37, uxecw wrote:
> Thank you for filling out a Git bug report!
> Please answer the following questions to help us understand your issue.
> 
> What did you do before the bug happened? (Steps to reproduce your issue)
> Rebasing.
> I entered `git commit —amend` (one hypen istead of two) accidently and it
> passed as defacto `git commit —all —message "end"`.
> I think because of the missing space git should have rejected the given
> input.
> 
> What did you expect to happen? (Expected behavior)
> Input should have been rejected
> 
> What happened instead? (Actual behavior)
> `git commit —all —message "end"`

I believe this is standard Unix behaviour.  One can combine
single-character options, including a final single-character option that
takes an argument, and the argument can be appended to the option.

For example, I frequently type "git commit -svS", and I could well type
"git commit -svS0223b187" (my OpenPGP key ID).  That also works
similarly with OpenSSH: the command "ssh -CoUser=foo server" works just
fine.

So I think it's best for Git to preserve the existing behaviour since
it's standard for other tools as well (and, I believe, the
POSIX-mandated behaviour).
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

      reply	other threads:[~2023-07-14  0:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 13:04 Bug Report - Git does not require a space between shorthand flags and the commit-message uxecw
2023-07-14  0:48 ` brian m. carlson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLCbWn2qXZhmf8XD@tapette.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=uxecw@student.kit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).