From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch: reject --no-ipv[46]
Date: Tue, 18 Jul 2023 17:59:08 -0400 [thread overview]
Message-ID: <ZLcLLGet7GDmqfRb@nand.local> (raw)
In-Reply-To: <xmqqedl4gag8.fsf@gitster.g>
On Tue, Jul 18, 2023 at 02:45:59PM -0700, Junio C Hamano wrote:
> parse-options.h | 8 ++++----
> t/t5516-fetch-push.sh | 11 +++++++++++
> 2 files changed, 15 insertions(+), 4 deletions(-)
The first patch is an obvious improvement, and the same is true of the
second one. Both of these look good to me.
Thanks,
Taylor
prev parent reply other threads:[~2023-07-18 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 21:34 [PATCH] parse-options: introduce OPT_IPVERSION() Junio C Hamano
2023-07-18 21:45 ` [PATCH] fetch: reject --no-ipv[46] Junio C Hamano
2023-07-18 21:59 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLcLLGet7GDmqfRb@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).