From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] send-email: drop FakeTerm hack
Date: Tue, 8 Aug 2023 16:13:14 -0400 [thread overview]
Message-ID: <ZNKh2lzaRUjeU9AF@nand.local> (raw)
In-Reply-To: <20230808181436.GA2097200@coredump.intra.peff.net>
On Tue, Aug 08, 2023 at 02:14:36PM -0400, Jeff King wrote:
> The smaller change is to implement:
>
> sub IN { return undef }
>
> for FakeTerm, which would then behave according to 5906f54e47's "no tty"
> behavior. But after reading through the relevant history, I'm fairly
> convinced that just dropping it is the right path. If it were actually
> kicking in ever, people would be complaining about the obscure
> "$term->IN is not defined" error message from perl.
All makes sense. Thanks for the detailed commit message, as always :-).
Thanks,
Taylor
next prev parent reply other threads:[~2023-08-08 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 18:09 [PATCH 0/2] fix git-send-email with recent versions of Term::ReadLine::Gnu Jeff King
2023-08-08 18:14 ` [PATCH 1/2] send-email: drop FakeTerm hack Jeff King
2023-08-08 20:13 ` Taylor Blau [this message]
2023-08-08 18:15 ` [PATCH 2/2] send-email: avoid creating more than one Term::ReadLine object Jeff King
2023-08-08 20:16 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNKh2lzaRUjeU9AF@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).