* [PATCH] t0040: declare non-tab indentation to be okay in this script
@ 2023-08-08 10:37 Johannes Schindelin via GitGitGadget
2023-08-08 20:19 ` Taylor Blau
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2023-08-08 10:37 UTC (permalink / raw)
To: git; +Cc: Johannes Schindelin, Johannes Schindelin
From: Johannes Schindelin <johannes.schindelin@gmx.de>
By necessity, this script needs to verify that certain Git output
matches expectations, including text indented with spaces instead of
tabs.
Most recently, such a check was introduced in 448abbba6347 (short help:
allow multi-line opthelp, 2023-07-18) which is reported by `git diff
--check 448abbba6347^!` as having whitespace issues.
Let's not complain about this because it is intentional.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
t0040: declare non-tab indentation to be okay in this script
When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the
Pull Request's check-whitespace run failed. Let's prevent having future
contributors from also running into this type of issue when modifying
t0040.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1568%2Fdscho%2Fsuppress-t0040-whitespace-error-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1568/dscho/suppress-t0040-whitespace-error-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1568
t/.gitattributes | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/.gitattributes b/t/.gitattributes
index 9930e283512..b9cea1795d8 100644
--- a/t/.gitattributes
+++ b/t/.gitattributes
@@ -22,3 +22,4 @@ t[0-9][0-9][0-9][0-9]/* -whitespace
/t7500/* eol=lf
/t8005/*.txt eol=lf
/t9*/*.dump eol=lf
+/t0040*.sh whitespace=-indent-with-non-tab
base-commit: 448abbba63471153df6ba520a5621595557ce3c8
--
gitgitgadget
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t0040: declare non-tab indentation to be okay in this script
2023-08-08 10:37 [PATCH] t0040: declare non-tab indentation to be okay in this script Johannes Schindelin via GitGitGadget
@ 2023-08-08 20:19 ` Taylor Blau
0 siblings, 0 replies; 2+ messages in thread
From: Taylor Blau @ 2023-08-08 20:19 UTC (permalink / raw)
To: Johannes Schindelin via GitGitGadget; +Cc: git, Johannes Schindelin
On Tue, Aug 08, 2023 at 10:37:34AM +0000, Johannes Schindelin via GitGitGadget wrote:
> ---
> t0040: declare non-tab indentation to be okay in this script
>
> When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the
> Pull Request's check-whitespace run failed. Let's prevent having future
> contributors from also running into this type of issue when modifying
> t0040.
Thanks for hardening these up. This looks obviously correct to me!
Thanks,
Taylor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-08 20:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 10:37 [PATCH] t0040: declare non-tab indentation to be okay in this script Johannes Schindelin via GitGitGadget
2023-08-08 20:19 ` Taylor Blau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).