From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: "René Scharfe" <l.s.r@web.de>
Cc: Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>,
Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] parse-options: add int value pointer to struct option
Date: Mon, 18 Sep 2023 12:28:16 +0200 [thread overview]
Message-ID: <ZQgmQJvN0phJsFjz@ugly> (raw)
In-Reply-To: <2349e897-9e0d-4341-86fc-9da117a1eb48@web.de>
On Mon, Sep 18, 2023 at 11:53:19AM +0200, René Scharfe wrote:
>Am 11.09.23 um 21:19 schrieb Junio C Hamano:
>> Yup, that does cross my mind, even though I would have used
>>
>> union {
>> void *void_ptr;
>> int *int_ptr;
>> } value;
>>
>> or something without a rather meaningless 'u'.
>
>OK, but I neglected to ask what we would get out of throwing different
>types into the same bin.
>It complicates type safety by making it impossible for the parser to
>distinguish the used type. [...]
>
this is somewhat ironic, given that using a union has some semantic
value by illustrating that the fields are mutually exclusive.
but i'm not sure that the checking is really important here, given that
the initializers are inside centralized macros anyway.
regards
next prev parent reply other threads:[~2023-09-18 10:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 21:10 [PATCH 1/2] parse-options: add int value pointer to struct option René Scharfe
2023-09-09 21:14 ` [PATCH 2/2] parse-options: use and require int pointer for OPT_CMDMODE René Scharfe
2023-09-10 10:18 ` Oswald Buddenhagen
2023-09-11 20:11 ` René Scharfe
2023-09-12 8:40 ` Jeff King
2023-09-16 17:45 ` Junio C Hamano
2023-09-18 9:28 ` René Scharfe
2023-09-18 10:10 ` Oswald Buddenhagen
2023-09-19 7:41 ` René Scharfe
2023-09-21 11:07 ` [PATCH] am: fix error message in parse_opt_show_current_patch() Oswald Buddenhagen
2023-09-21 19:09 ` Junio C Hamano
2023-09-21 19:28 ` Oswald Buddenhagen
2023-09-18 13:33 ` [PATCH 2/2] parse-options: use and require int pointer for OPT_CMDMODE Phillip Wood
2023-09-18 17:11 ` Junio C Hamano
2023-09-18 19:48 ` Phillip Wood
2023-10-03 8:49 ` René Scharfe
2023-10-03 17:15 ` Junio C Hamano
2023-09-19 7:47 ` René Scharfe
2023-09-11 19:12 ` Junio C Hamano
2023-09-11 20:11 ` René Scharfe
2023-09-19 9:40 ` Oswald Buddenhagen
2023-09-20 8:18 ` René Scharfe
2023-09-21 10:40 ` Oswald Buddenhagen
2023-10-03 8:49 ` René Scharfe
2023-10-03 9:38 ` Oswald Buddenhagen
2023-10-03 17:54 ` René Scharfe
2023-10-03 18:24 ` Oswald Buddenhagen
2023-09-10 18:40 ` [PATCH 1/2] parse-options: add int value pointer to struct option Taylor Blau
2023-09-11 19:19 ` Junio C Hamano
2023-09-11 22:28 ` Oswald Buddenhagen
2023-09-18 11:34 ` Kristoffer Haugsbakk
2023-09-18 9:53 ` René Scharfe
2023-09-18 10:28 ` Oswald Buddenhagen [this message]
2023-09-18 16:17 ` Junio C Hamano
2023-09-20 11:34 ` René Scharfe
2023-09-11 20:12 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQgmQJvN0phJsFjz@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).