From: Taylor Blau <me@ttaylorr.com>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Phillip Wood <phillip.wood123@gmail.com>,
Christian Couder <christian.couder@gmail.com>,
Charvi Mendiratta <charvi077@gmail.com>,
Marc Branchaud <marcnarc@xiplink.com>
Subject: Re: [RESEND v2] git-rebase.txt: rewrite docu for fixup/squash (again)
Date: Mon, 23 Oct 2023 12:59:49 -0400 [thread overview]
Message-ID: <ZTamhY1sTpp1N6n+@nand.local> (raw)
In-Reply-To: <20231023130016.1093356-1-oswald.buddenhagen@gmx.de>
On Mon, Oct 23, 2023 at 03:00:16PM +0200, Oswald Buddenhagen wrote:
> ---
> Documentation/git-rebase.txt | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
The new documentation below looks fine, and I don't have strong
feelings beyond the proposed modifications.
The line wrapping is a little odd: it looks like each sentence begins on
a its own line. Did you mean for there to be a visual separation between
those sentences in the rendered doc? If so, replace the single line feed
with a pair of them.
If not, this looks good to me as-is.
Thanks,
Taylor
next prev parent reply other threads:[~2023-10-23 16:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 13:00 [RESEND v2] git-rebase.txt: rewrite docu for fixup/squash (again) Oswald Buddenhagen
2023-10-23 16:01 ` Phillip Wood
2023-10-23 17:52 ` Oswald Buddenhagen
2023-10-24 9:22 ` Phillip Wood
2023-10-24 17:19 ` Junio C Hamano
2023-10-23 16:59 ` Taylor Blau [this message]
2023-10-24 21:31 ` Oswald Buddenhagen
2023-10-24 14:01 ` Marc Branchaud
2023-10-24 21:19 ` Oswald Buddenhagen
2023-10-27 12:39 ` Marc Branchaud
2023-10-27 13:08 ` Oswald Buddenhagen
2023-10-25 10:29 ` [PATCH v3] " Oswald Buddenhagen
2023-10-27 13:14 ` Marc Branchaud
2023-10-27 16:12 ` Oswald Buddenhagen
2023-10-27 23:34 ` Junio C Hamano
2023-10-31 18:48 ` Marc Branchaud
2023-10-30 9:55 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTamhY1sTpp1N6n+@nand.local \
--to=me@ttaylorr.com \
--cc=charvi077@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marcnarc@xiplink.com \
--cc=oswald.buddenhagen@gmx.de \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).