From: Josh Steadmon <steadmon@google.com>
To: Glen Choo <glencbz@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Adam Majer <adamm@zombino.com>
Subject: Re: [PATCH] setup: recognize bare repositories with packed-refs
Date: Mon, 27 Nov 2023 11:42:44 -0800 [thread overview]
Message-ID: <ZWTxNBcF1wLufJPj@google.com> (raw)
In-Reply-To: <CA+we5Gqp2nhoXyqJKJiXQMDx-ZXcnNGHu3wnwERWREng2XHHuQ@mail.gmail.com>
On 2023.11.20 17:31, Glen Choo wrote:
> On Mon, Nov 20, 2023 at 7:24 AM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Adam Majer <adamm@zombino.com> writes:
> >
> > > In a garbage collected bare git repository, the refs/ subdirectory is
> > > empty. In use-cases when such a repository is directly added into
> > > another repository, it no longer is detected as valid.
> >
> > Josh & Glen [*], isn't this a layout that we explicitly discourage and
> > eventually plan to forbid anyway?
>
> If my recollection of [1] serves me correctly, we didn't come to a
> strong conclusion on whether or not to forbid bare repositories in the
> working tree, particularly because it would leave existing repos (like
> Git LFS) high and dry. Though personally, I'd be happy to see a
> version of Git that forbade bare repositories in the working tree.
>
> I don't really recall the bare repo tracing bits, so I'll leave that to Josh.
>
> [1] https://lore.kernel.org/git/kl6lsfqpygsj.fsf@chooglen-macbookpro.roam.corp.google.com/
Yeah, my understanding was that we don't want to forbid bare
repositories outright, which is why we have the config option to let
end-users choose what to do with them.
next prev parent reply other threads:[~2023-11-27 19:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 20:25 [PATCH] setup: recognize bare repositories with packed-refs Adam Majer
2023-11-17 20:32 ` Adam Majer
2023-11-17 20:44 ` Adam Majer
2023-11-19 23:24 ` Junio C Hamano
2023-11-20 9:31 ` Glen Choo
2023-11-27 19:42 ` Josh Steadmon [this message]
2023-11-20 9:43 ` Adam Majer
2023-11-27 19:44 ` Josh Steadmon
2023-11-28 14:14 ` Adam Majer
2023-11-28 14:28 ` Adam Majer
2023-11-28 18:45 ` Josh Steadmon
2023-11-28 19:04 ` Jeff King
2023-11-29 10:13 ` Patrick Steinhardt
2023-12-06 20:10 ` Jeff King
2023-12-07 7:01 ` Patrick Steinhardt
2023-12-07 7:34 ` Jeff King
2023-12-07 8:37 ` Patrick Steinhardt
2023-11-29 21:30 ` Taylor Blau
2023-12-06 21:08 ` Jeff King
2023-12-07 8:20 ` Adam Majer
2023-12-08 21:09 ` Taylor Blau
2023-12-12 1:22 ` Jeff King
2023-12-08 18:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWTxNBcF1wLufJPj@google.com \
--to=steadmon@google.com \
--cc=adamm@zombino.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=glencbz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).