From: Patrick Steinhardt <ps@pks.im>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/10] t: more compatibility fixes with reftables
Date: Thu, 30 Nov 2023 08:06:44 +0100 [thread overview]
Message-ID: <ZWg0hJNsIR---SVI@tanuki> (raw)
In-Reply-To: <ZWfJp80vzVhbdH89@nand.local>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Wed, Nov 29, 2023 at 06:30:47PM -0500, Taylor Blau wrote:
> On Wed, Nov 29, 2023 at 08:24:36AM +0100, Patrick Steinhardt wrote:
> > Hi,
> >
> > this is the second patch series that refactors tests to become
> > compatible with the upcoming reftables backend. It's in the same spirit
> > as the first round of patches [1], where most of the refactorings are to
> > use plumbing tools to access refs or the reflog instead of modifying
> > on-disk data structures directly.
>
> All looks good to me. Thanks for a pleasant read :-).
>
> Thanks,
> Taylor
If you don't mind, I'll refrain from sending a v2 only to start piping
output into git-update-ref(1) directly. I'll incorporate that feedback
though if there is a need for v2 due to other reasons.
Thanks for your review!
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-11-30 7:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 7:24 [PATCH 00/10] t: more compatibility fixes with reftables Patrick Steinhardt
2023-11-29 7:24 ` [PATCH 01/10] t0410: mark tests to require the reffiles backend Patrick Steinhardt
2023-11-29 22:19 ` Taylor Blau
2023-11-29 7:24 ` [PATCH 02/10] t1400: split up generic reflog tests from the reffile-specific ones Patrick Steinhardt
2023-11-29 7:24 ` [PATCH 03/10] t1401: stop treating FETCH_HEAD as real reference Patrick Steinhardt
2023-11-29 7:24 ` [PATCH 04/10] t1410: use test-tool to create empty reflog Patrick Steinhardt
2023-11-29 7:24 ` [PATCH 05/10] t1417: make `reflog --updateref` tests backend agnostic Patrick Steinhardt
2023-11-29 7:25 ` [PATCH 06/10] t3310: stop checking for reference existence via `test -f` Patrick Steinhardt
2023-11-29 7:25 ` [PATCH 07/10] t4013: simplify magic parsing and drop "failure" Patrick Steinhardt
2023-11-29 7:25 ` [PATCH 08/10] t5401: speed up creation of many branches Patrick Steinhardt
2023-11-29 22:25 ` Taylor Blau
2023-11-29 7:25 ` [PATCH 09/10] t5551: stop writing packed-refs directly Patrick Steinhardt
2023-11-29 22:26 ` Taylor Blau
2023-11-29 7:25 ` [PATCH 10/10] t6301: write invalid object ID via `test-tool ref-store` Patrick Steinhardt
2023-11-29 23:30 ` [PATCH 00/10] t: more compatibility fixes with reftables Taylor Blau
2023-11-30 7:06 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWg0hJNsIR---SVI@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).