From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/9] config: reject bogus values for core.checkstat
Date: Fri, 8 Dec 2023 17:50:15 -0500 [thread overview]
Message-ID: <ZXOdp+uHCe+Daz4O@nand.local> (raw)
In-Reply-To: <20231207072404.GA1277973@coredump.intra.peff.net>
On Thu, Dec 07, 2023 at 02:24:04AM -0500, Jeff King wrote:
> If you feed nonsense config like:
>
> git -c core.checkstat=foobar status
>
> we'll silently ignore the unknown value, rather than reporting an error.
> This goes all the way back to c08e4d5b5c (Enable minimal stat checking,
> 2013-01-22).
>
> Detecting and complaining now is technically a backwards-incompatible
> change, but I don't think anybody has any reason to use an invalid value
> here. There are no historical values we'd want to allow for backwards
> compatibility or anything like that. We are better off loudly telling
> the user that their config may not be doing what they expect.
I think this is a good instance of "yes, this is a backwards
incompatible change, but the behavior we're breaking is so obviously
broken already that it's not worth maintaining compatibility."
Well reasoned, I am definitely in favor here.
Thanks,
Taylor
next prev parent reply other threads:[~2023-12-08 22:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 7:23 [PATCH 0/9] bonus config cleanups Jeff King
2023-12-07 7:24 ` [PATCH 1/9] config: reject bogus values for core.checkstat Jeff King
2023-12-08 22:50 ` Taylor Blau [this message]
2023-12-07 7:24 ` [PATCH 2/9] git_xmerge_config(): prefer error() to die() Jeff King
2023-12-07 7:24 ` [PATCH 3/9] imap-send: don't use git_die_config() inside callback Jeff King
2023-12-07 8:57 ` Patrick Steinhardt
2023-12-08 22:58 ` Taylor Blau
2023-12-11 7:43 ` Patrick Steinhardt
2023-12-12 1:37 ` Jeff King
2023-12-07 7:25 ` [PATCH 4/9] config: use config_error_nonbool() instead of custom messages Jeff King
2023-12-07 7:25 ` [PATCH 5/9] diff: give more detailed messages for bogus diff.* config Jeff King
2023-12-07 7:26 ` [PATCH 6/9] config: use git_config_string() for core.checkRoundTripEncoding Jeff King
2023-12-07 7:26 ` [PATCH 7/9] push: drop confusing configset/callback redundancy Jeff King
2023-12-07 7:26 ` [PATCH 8/9] gpg-interface: drop pointless config_error_nonbool() checks Jeff King
2023-12-07 7:26 ` [PATCH 9/9] sequencer: simplify away extra git_config_string() call Jeff King
2023-12-07 8:58 ` [PATCH 0/9] bonus config cleanups Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXOdp+uHCe+Daz4O@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).