From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Karthik Nayak" <karthik.188@gmail.com>
Subject: Re: [PATCH v2] git-prompt: stop manually parsing HEAD with unknown ref formats
Date: Thu, 4 Jan 2024 12:51:05 +0100 [thread overview]
Message-ID: <ZZabqfPDcA1jtmZS@ugly> (raw)
In-Reply-To: <ef4e36a5a40c369da138242a8fdc9e12a846613b.1704356313.git.ps@pks.im>
On Thu, Jan 04, 2024 at 09:21:53AM +0100, Patrick Steinhardt wrote:
>--- a/contrib/completion/git-prompt.sh
>+++ b/contrib/completion/git-prompt.sh
>@@ -408,7 +408,7 @@ __git_ps1 ()
>
> local repo_info rev_parse_exit_code
> repo_info="$(git rev-parse --git-dir --is-inside-git-dir \
>- --is-bare-repository --is-inside-work-tree \
>+ --is-bare-repository --is-inside-work-tree --show-ref-format \
> --short HEAD 2>/dev/null)"
>
that makes me wonder whether adding support for `--symbolic-ref HEAD`
here would not be the cleaner solution? and why stop there, and not add
a few more ps1 would need, like --upstream and --sequencer-state?
(though arguably, this overloading of `rev-parse` should be deprecated
in favor of a new generalized `query` command, maybe even unified with
`var`.)
next prev parent reply other threads:[~2024-01-04 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 11:37 [PATCH] git-prompt: stop manually parsing HEAD Patrick Steinhardt
2023-11-24 18:09 ` Eric Sunshine
2023-11-24 18:28 ` SZEDER Gábor
2023-12-01 7:34 ` Patrick Steinhardt
2024-01-04 8:21 ` [PATCH v2] git-prompt: stop manually parsing HEAD with unknown ref formats Patrick Steinhardt
2024-01-04 11:51 ` Oswald Buddenhagen [this message]
2024-01-04 14:47 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZabqfPDcA1jtmZS@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).