git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2025, #01; Mon, 7)
Date: Tue, 8 Apr 2025 08:22:44 +0200	[thread overview]
Message-ID: <Z_TAtJ9LEeHo2AQN@pks.im> (raw)
In-Reply-To: <xmqqtt6znch3.fsf@gitster.g>

On Mon, Apr 07, 2025 at 04:49:28PM +0000, Junio C Hamano wrote:
> * pb/perf-test-fixes (2025-03-28) 2 commits
>  - p9210: fix 'scalar clone' when running from a detached HEAD
>  - p7821: fix test_perf invocation for prereqs
> 
>  "make perf" fixes.
> 
>  Will merge to 'next'?
>  cf. <Z-pD1puYT87YKAd4@pks.im>
>  source: <pull.1936.git.git.1743181669.gitgitgadget@gmail.com>

I had one question around empty prereqs introduced by the patch that
wasn't yet answered. Based on my testing empty prereqs do work just fine
though and evaluate to true, so the patch series looks fine to me.

> * ps/misc-build-fixes (2025-04-01) 5 commits
>  - ci: use Visual Studio for win+meson job on GitHub Workflows
>  - meson: distinguish build and target host binaries
>  - meson: respect 'tests' build option in contrib
>  - gitweb: fix generation of "gitweb.js"
>  - meson: fix handling of '-Dcurl=auto'
> 
>  Random build fixes.
> 
>  Will merge to 'next'?
>  cf. <CAOLa=ZQ8bTn-prAs2ycLdLLjVaLQL4GtLw_gFsvAcx_6j=MBjA@mail.gmail.com>
>  source: <20250331-b4-pks-collect-build-fixes-v2-0-6b06136808f3@pks.im>

I think this one should be ready to be merged.

> * ab/pathspec-sign-compare-workaround (2025-04-01) 1 commit
>  - pathspec: fix sign comparison warnings
> 
>  Some warnings from "-Wsign-compare" for pathspec.c have been
>  squelched.
>  
>  Will merge to 'next'?
>  source: <127c3010-4b23-436e-a07d-e6031e746113@gmail.com>

I had another read just now, the patch looks good to me.

> * jt/rev-list-z (2025-03-21) 5 commits
>  - rev-list: support NUL-delimited --missing option
>  - rev-list: support NUL-delimited --boundary option
>  - rev-list: support delimiting objects with NUL bytes
>  - rev-list: refactor early option parsing
>  - rev-list: inline `show_object_with_name()` in `show_object()`
> 
>  "git rev-list" learns machine-parsable output format that delimits
>  each field with NUL.
> 
>  Will merge to 'next'?
>  source: <20250319183410.1225428-1-jltobler@gmail.com>

Same here, I did scan through the series again and didn't notice
anything objectionable.

> * sk/clar-trailer-urlmatch-norm-test (2025-03-04) 2 commits
>  - t/unit-tests: convert urlmatch-normalization test to clar
>  - t/unit-tests: convert trailer test to use clar
> 
>  A few traditional unit tests have been rewritten to use the clar
>  framework.
> 
>  Will merge to 'next'?
>  cf. <xmqqzfi0pthr.fsf@gitster.g>
>  source: <20250304113323.10564-1-kuforiji98@gmail.com>

Yup. I didn't review this on-list, but already reviewed it internally
before Seyi sent it to the mailing list.

Patrick

  reply	other threads:[~2025-04-08  6:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 16:49 What's cooking in git.git (Apr 2025, #01; Mon, 7) Junio C Hamano
2025-04-08  6:22 ` Patrick Steinhardt [this message]
2025-04-08 14:50   ` Junio C Hamano
2025-04-09 11:31     ` Philippe Blain
2025-04-09 15:59       ` Junio C Hamano
2025-04-08  8:20 ` Karthik Nayak
2025-04-09 11:24 ` Philippe Blain
2025-04-09 16:01   ` Junio C Hamano
2025-06-05 12:51   ` Junio C Hamano
2025-06-05 15:10     ` Philippe Blain
2025-06-05 18:29       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_TAtJ9LEeHo2AQN@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).