From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeff King <peff@peff.net>
Cc: Nikolaus Rath <nikolaus@quadrature.ai>, git@vger.kernel.org
Subject: Re: 'safe.directory' setting ignored for some operations?
Date: Fri, 11 Apr 2025 00:47:24 +0000 [thread overview]
Message-ID: <Z_hmnPoPjXQm6lyP@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <20250410224223.GA3191424@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On 2025-04-10 at 22:42:23, Jeff King wrote:
> Yeah, that's true in v2.48.0 and later. (I tried it after writing the
> earlier email and was a little puzzled that it works with --no-local but
> not otherwise, but it sounds like that's known).
It is. The reason for that is that we try to hardlink if `--no-local`
is not provided, which has all the normal security concerns across
ownership boundaries. However, `--no-local` uses the normal
`git-upload-pack` mechanism, which we know is secure on untrusted
repositories.
One thing we could do to improve things is detect if the repository is
owned by another user and just set `--no-local` automatically, but
that's a #leftoverbits for someone.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2025-04-11 0:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPzgaL2Q4v0LMSek=osugTDCDww9D-Tg+tDsFhFvRSVXFR8g6Q@mail.gmail.com>
2025-04-10 13:21 ` 'safe.directory' setting ignored for some operations? Nikolaus Rath
2025-04-10 21:35 ` Jeff King
2025-04-10 22:13 ` brian m. carlson
2025-04-10 22:42 ` Jeff King
2025-04-11 0:47 ` brian m. carlson [this message]
2025-04-11 8:17 ` Nikolaus Rath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_hmnPoPjXQm6lyP@tapette.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=nikolaus@quadrature.ai \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox