From: Taylor Blau <me@ttaylorr.com>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] diffcore-delta: avoid ignoring final 'line' of file
Date: Thu, 11 Jan 2024 16:45:47 -0500 [thread overview]
Message-ID: <ZaBhi+0LUyYcXL2X@nand.local> (raw)
In-Reply-To: <pull.1637.git.1705006074626.gitgitgadget@gmail.com>
On Thu, Jan 11, 2024 at 08:47:54PM +0000, Elijah Newren via GitGitGadget wrote:
> ---
> diffcore-delta.c | 4 ++++
> t/t4001-diff-rename.sh | 19 +++++++++++++++++++
> 2 files changed, 23 insertions(+)
Nice find and fix. This patch LGTM.
Thanks,
Taylor
next prev parent reply other threads:[~2024-01-11 21:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 20:47 [PATCH] diffcore-delta: avoid ignoring final 'line' of file Elijah Newren via GitGitGadget
2024-01-11 21:45 ` Taylor Blau [this message]
2024-01-11 23:00 ` Junio C Hamano
2024-01-13 1:45 ` Elijah Newren
2024-01-13 6:21 ` Junio C Hamano
2024-01-19 1:54 ` Elijah Newren
2024-01-19 3:06 ` Junio C Hamano
2024-01-19 5:05 ` Elijah Newren
2024-01-19 6:27 ` Junio C Hamano
2024-01-13 4:26 ` [PATCH v2] " Elijah Newren via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaBhi+0LUyYcXL2X@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).