From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] Comment style fixes
Date: Tue, 30 Jan 2024 07:10:08 +0100 [thread overview]
Message-ID: <ZbiSwAbRaxXXfLMk@tanuki> (raw)
In-Reply-To: <20240129202839.2234084-1-gitster@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Mon, Jan 29, 2024 at 12:28:36PM -0800, Junio C Hamano wrote:
> Among comments in the traditional /* single liner */ ones, our
> reviews seem to have missed a few // comments. While they are not
> illegal per-se, they look out of place mixed with the /* ... */
> style comments, which is the prevailing style used in this project.
>
> Fix those small number of style violations in our own code; files
> with borrowed code that have // comments as the prevalent style are
> left untouched.
These changes look obviously good to me, thanks!
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-01-30 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 20:28 [PATCH 0/3] Comment style fixes Junio C Hamano
2024-01-29 20:28 ` [PATCH 1/3] builtin/worktree: comment " Junio C Hamano
2024-01-29 20:28 ` [PATCH 2/3] merge-ort.c: comment style fix Junio C Hamano
2024-01-29 20:28 ` [PATCH 3/3] reftable/pq_test: " Junio C Hamano
2024-01-30 6:10 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbiSwAbRaxXXfLMk@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).