From: Taylor Blau <me@ttaylorr.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] pack-objects: enable multi-pack reuse via `feature.experimental`
Date: Mon, 5 Feb 2024 17:48:18 -0500 [thread overview]
Message-ID: <ZcFlshJhJJIOsXqJ@nand.local> (raw)
In-Reply-To: <ZaeCf1KCwAUCeBPy@tanuki>
On Wed, Jan 17, 2024 at 08:32:15AM +0100, Patrick Steinhardt wrote:
> I would like to avoid cases like this by laying out a plan for when
> experimental features become the new default. It could be as simple as
> "Let's wait N releases and then mark it stable". But having something
> and documenting such a plan in our code makes it a lot more actionable
> to promote those features to become stable eventually.
Fair point. I think that these have been mostly ad-hoc. Unfortunately,
when folks leave the project or change their attention to working on a
different feature, things that were left in feature.experimental may be
forgotten about.
When this inevitably happens, it would be nice to have a written record
(either in the repository, or here on the mailing list) so that other
folks can take up the mantle and graduate those feature(s) as
appropriate.
> I know that this is not in any way specific to your patch, but I thought
> this was a good opportunity to start this discussion. If we can agree on
> my opinion then it would be great to add a comment to the experimental
> feature to explain such an exit criterion.
I don't have a ton to add here for a graduation plan other than it would
be nice to enable it eventually, likely after a few releases without any
show-stopping bug reports.
> Other than that this patch looks good to me, thanks!
Thanks again for the review!
Thanks,
Taylor
next prev parent reply other threads:[~2024-02-05 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 19:03 [PATCH 0/2] pack-objects: enable multi-pack reuse via feature.experimental Taylor Blau
2024-01-16 19:03 ` [PATCH 1/2] t5332-multi-pack-reuse.sh: extract pack-objects helper functions Taylor Blau
2024-01-17 7:32 ` Patrick Steinhardt
2024-02-05 22:44 ` Taylor Blau
2024-01-16 19:03 ` [PATCH 2/2] pack-objects: enable multi-pack reuse via `feature.experimental` Taylor Blau
2024-01-17 7:32 ` Patrick Steinhardt
2024-02-05 22:48 ` Taylor Blau [this message]
2024-02-05 22:50 ` [PATCH v2 0/2] pack-objects: enable multi-pack reuse via feature.experimental Taylor Blau
2024-02-05 22:50 ` [PATCH v2 1/2] t5332-multi-pack-reuse.sh: extract pack-objects helper functions Taylor Blau
2024-02-06 7:25 ` Patrick Steinhardt
2024-02-05 22:50 ` [PATCH v2 2/2] pack-objects: enable multi-pack reuse via `feature.experimental` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcFlshJhJJIOsXqJ@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).