From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 0/3] t7800: fix quoting of looped test bodies
Date: Thu, 21 Mar 2024 14:48:37 +0100 [thread overview]
Message-ID: <Zfw6tX-79WisvYsL@tanuki> (raw)
In-Reply-To: <cover.1711028473.git.ps@pks.im>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Thu, Mar 21, 2024 at 02:47:20PM +0100, Patrick Steinhardt wrote:
> Hi,
>
> SZEDER made me aware [1] of a quoting issue with some test refactorings
> in t7800 I recently introduced when refactoring the tests to run in a
> loop. This patch series fixes those issues and also adds a paragraph to
> "t/README" to document how this is supposed to be done properly.
>
> Thanks!
>
> Patrick
>
> [1]: https://lore.kernel.org/git/20240308221229.GA1908@szeder.dev/
I forgot to mention: this is built on top of
ps/difftool-dir-diff-exit-code at eb84c8b6ce (git-difftool--helper:
honor `--trust-exit-code` with `--dir-diff`, 2024-02-20).
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-03-21 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 13:47 [PATCH 0/3] t7800: fix quoting of looped test bodies Patrick Steinhardt
2024-03-21 13:47 ` [PATCH 1/3] t7800: improve test descriptions with empty arguments Patrick Steinhardt
2024-03-21 13:47 ` [PATCH 2/3] t7800: use single quotes for test bodies Patrick Steinhardt
2024-03-21 13:47 ` [PATCH 3/3] t/README: document how to loop around test cases Patrick Steinhardt
2024-03-21 17:12 ` Junio C Hamano
2024-03-22 2:05 ` Patrick Steinhardt
2024-03-22 2:12 ` Junio C Hamano
2024-03-21 13:48 ` Patrick Steinhardt [this message]
2024-03-22 2:23 ` [PATCH v2 0/3] t7800: fix quoting of looped test bodies Patrick Steinhardt
2024-03-22 2:23 ` [PATCH v2 1/3] t7800: improve test descriptions with empty arguments Patrick Steinhardt
2024-03-22 2:23 ` [PATCH v2 2/3] t7800: use single quotes for test bodies Patrick Steinhardt
2024-03-22 2:23 ` [PATCH v2 3/3] t/README: document how to loop around test cases Patrick Steinhardt
2024-03-22 14:37 ` [PATCH v2 0/3] t7800: fix quoting of looped test bodies Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfw6tX-79WisvYsL@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).