From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 517694A02 for ; Fri, 22 Mar 2024 02:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.27 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711072894; cv=none; b=tVGX2P+uS33NPKpTI4oiSv44qRi4YQjZbbv5y2yvnSRJHXpkaC80jS7X94I0fXsXIDYq4HAoZzgPOMNecb65zBSYAS4qSucOQPSx7EVAvOHZ3dq2lvsBsnRg1EBFF2R74QyY16I1v7TvkJ6FWFwK2YJjqDKW1CkraLJwHihmbRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711072894; c=relaxed/simple; bh=yfGM2Wbj30MVQW5FCvCb0x76PMby87jl9LO//t7Tcck=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uyZdSCCpXYo3fjMBJOnOFAV76eX0R4UdHIYa1hC50ZrX3rslhAWtsN/jKCGxjeBJJs9ZKEd5vg9cey5k5kYqGqbf7Qxpb4M6Zs6qs3CJCs/DrqeV9b4KDetmg89wED6XCZaqJGiH2ffnO43tZH9Jn3F3zr1cNZ3I1GtNbBuERxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=bcjBPqtc; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=fwPHj00S; arc=none smtp.client-ip=66.111.4.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="bcjBPqtc"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="fwPHj00S" Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 234935C0072; Thu, 21 Mar 2024 22:01:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 21 Mar 2024 22:01:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1711072891; x=1711159291; bh=3Za35tixiS B2t5XvXzNktr9VeMSmS1IuJ7ra3T+rKOw=; b=bcjBPqtcjKzm2bMmBuC9XFYlnd u/40pAJ85pwmAz1Vj5BqC3XvghCnkgtSnxBVbQeTaGCzg4fZ8qdPwcBdt0Xwt07m 8OfNBVS+Z2DwLehaUFVZ4XGiKs+/4lHrXmkC2RAenwCeaXm2pBhzgBQz0u7GYYmU tOjyP8Ir8OFYpeWdIZoR3cmrHs+Qu+sFS1iA2f6tsAbPsT1FFS/MIwA/7p0lXWMQ jkzf7nln5Z0KR6sOY1Oiy7tXwqOebO7mSI+PM5syFMI5OXMC3hUSkfmvT3ZrY83s DtERKKf7j4D1SbafICitpIOUYtlTwWGzG+/aGsVXdEhlcpJbJwSJiblm4owQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1711072891; x=1711159291; bh=3Za35tixiSB2t5XvXzNktr9VeMSm S1IuJ7ra3T+rKOw=; b=fwPHj00S/djxx/Nl/qaolBSRDZWW06IOu6BiMvWHMzDR 9R4CUNO11jlbmB5zL9mrr700HBupWOFJT2ide+tGJ2U+NdhbCA8Eio6haFFoc2yl HogIaiI1IfBqSjn9l76K7mDjsJ6BodJnBS7reoIfAD0/8Bj1hdFKR0V6KTMkKTcY pWn+5DnIlPl6ku3dyzvotUOnK/LnVZ+u2fu2wxY8IzXUcTig0TeWBC5W0nKHDIFv Io+ylqWs5XuGz2pkJiEZkLrY1r6mOVc2/9FVdp652NYpdfkWrVsMJLBJ3ar6hhV4 hy+rdXi7IqN+H5XWIH2IVUjexKY4PignoA+fmt6qeA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleelgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeeukedtvedtffevleejtefgheehieegkeeluddvfeefgeehgfeltddtheejleffteen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpshesph hkshdrihhm X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Mar 2024 22:01:29 -0400 (EDT) Received: by vm-mail (OpenSMTPD) with ESMTPSA id 8455c119 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 22 Mar 2024 02:01:22 +0000 (UTC) Date: Fri, 22 Mar 2024 03:01:25 +0100 From: Patrick Steinhardt To: Junio C Hamano Cc: git@vger.kernel.org, "brian m. carlson" , rsbecker@nexbridge.com, Angelo Dureghello Subject: Re: [PATCH] t5601: exercise clones with "includeIf.*.onbranch" Message-ID: References: <72771da0-a0ef-4fd9-8071-6467cd7b6a6b@kernel-space.org> <0bede59a53862585c49bc635f82e44e983144a7f.1710246859.git.ps@pks.im> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p4CIHP67jwIi1op9" Content-Disposition: inline In-Reply-To: --p4CIHP67jwIi1op9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 12, 2024 at 01:38:26PM -0700, Junio C Hamano wrote: > Patrick Steinhardt writes: >=20 > > +test_expect_success 'clone with includeIf' ' > > + test_when_finished "rm -rf repo \"$HTTPD_DOCUMENT_ROOT_PATH/repo.git\= "" && > > + git clone --bare --no-local src "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" = && > > + > > + test_when_finished "rm \"$HOME\"/.gitconfig" && > > + cat >"$HOME"/.gitconfig <<-EOF && > > + [includeIf "onbranch:something"] > > + path =3D /does/not/exist.inc > > + EOF > > + git clone $HTTPD_URL/smart/repo.git repo > > +' >=20 > Hmph, isn't the end-user expectation more like if you clone with > "git clone -b something" then the configuration stored in the named > file to take effect, while "git clone" that would never place you on > that something branch would ignore that missing file? Is this only > the latter half of the pair? It probably is, but I'm not really sure to be honest. That's why I punted on it and just assert that it doesn't die. In any case I would claim that the current behaviour is really quite broken in Git v2.43: ``` $ cat >$HOME/.gitconfig <$HOME/include <$HOME/.gitconfig <$HOME/.gitconfig <