git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: vk <g@vkabc.me>, Karthik Nayak <karthik.188@gmail.com>,
	git@vger.kernel.org
Subject: Re: [GSoC] Microproject help
Date: Tue, 2 Apr 2024 11:52:04 +0200	[thread overview]
Message-ID: <ZgvVRK8VH2F9YKd1@tanuki> (raw)
In-Reply-To: <xmqqo7axvbd0.fsf@gitster.g>

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

On Thu, Mar 28, 2024 at 10:46:35PM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Hint: the `maintenance_task_pack_refs()` can in fact be converted to use
> > `refs_pack_refs()` instead. I was briefly considering doing that in [1],
> > but then didn't want to do such an unrelated refactoring in an already
> > long patch series.
> >
> > So if you decide to do that you should probably build on top of my patch
> > series to avoid conflicts.
> 
> As the microproject is a learning experience for skills to work well
> with others, we may want to suggest an area where there won't be
> much conflicts, i.e. skill to find an area that are relatively
> quiescent to avoid stepping each other's toes.
> 
> To be quite honest, I'd rather not to see a task that uses
> run_command() API and gets done in safe process isolation turned
> into an internal call by pure amateurs, unless competent mentors
> go through the change with fine toothed comb and make sure there are
> no unintended consequences and side effects of doing it in process.
> This is especially true for microprojects, where the primary focus
> is about learning the process of contribution and working with the
> community, and not about learning the existing codebase and API.

That's a fair remark indeed. I wonder whether we should remove this
microproject altogether.

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-04-02  9:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 13:10 [GSoC] Microproject help vk
2024-03-25 18:25 ` Karthik Nayak
2024-03-26 11:56   ` vk
2024-03-27  6:36     ` Patrick Steinhardt
2024-03-29  3:57       ` vk
2024-04-02 10:35         ` Patrick Steinhardt
2024-03-29  5:46       ` Junio C Hamano
2024-04-02  9:52         ` Patrick Steinhardt [this message]
2024-03-25 20:51 ` Eric Sunshine
2024-03-25 21:23   ` Junio C Hamano
2024-03-25 21:37     ` Eric Sunshine
2024-03-25 21:58       ` Junio C Hamano
2024-03-26  2:59         ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZgvVRK8VH2F9YKd1@tanuki \
    --to=ps@pks.im \
    --cc=g@vkabc.me \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).