git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ci: update coverity runs_on_pool reference
@ 2024-05-09 16:15 Jeff King
  2024-05-10  4:31 ` Patrick Steinhardt
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff King @ 2024-05-09 16:15 UTC (permalink / raw)
  To: git; +Cc: Patrick Steinhardt

Commit 2d65e5b6a6 (ci: rename "runs_on_pool" to "distro", 2024-04-12)
renamed this variable for the main CI workflow, as well as in the ci/
scripts. Because the coverity workflow also relies on those scripts to
install dependencies, it needs to be updated, too. Without this patch,
the coverity build fails because we lack libcurl.

Signed-off-by: Jeff King <peff@peff.net>
---
On top of ps/ci-test-with-jgit, though that is now in master.

 .github/workflows/coverity.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index 53cf12fe04..48341e81f4 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -45,7 +45,7 @@ jobs:
       - run: ci/install-dependencies.sh
         if: contains(matrix.os, 'ubuntu') || contains(matrix.os, 'macos')
         env:
-          runs_on_pool: ${{ matrix.os }}
+          distro: ${{ matrix.os }}
 
       # The Coverity site says the tool is usually updated twice yearly, so the
       # MD5 of download can be used to determine whether there's been an update.
-- 
2.45.0.414.g4009e73179

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ci: update coverity runs_on_pool reference
  2024-05-09 16:15 [PATCH] ci: update coverity runs_on_pool reference Jeff King
@ 2024-05-10  4:31 ` Patrick Steinhardt
  0 siblings, 0 replies; 2+ messages in thread
From: Patrick Steinhardt @ 2024-05-10  4:31 UTC (permalink / raw)
  To: Jeff King; +Cc: git

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

On Thu, May 09, 2024 at 12:15:06PM -0400, Jeff King wrote:
> Commit 2d65e5b6a6 (ci: rename "runs_on_pool" to "distro", 2024-04-12)
> renamed this variable for the main CI workflow, as well as in the ci/
> scripts. Because the coverity workflow also relies on those scripts to
> install dependencies, it needs to be updated, too. Without this patch,
> the coverity build fails because we lack libcurl.

Ah, I missed that one. Thanks for the fix, which looks obviously good to
me!

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-10  4:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-09 16:15 [PATCH] ci: update coverity runs_on_pool reference Jeff King
2024-05-10  4:31 ` Patrick Steinhardt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).