Re: What's cooking in git.git (May 2024, #04; Thu, 9)

[Patrick Steinhardt <ps@pks.im>]

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

On Fri, May 10, 2024 at 08:35:16AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Just in case you missed it, there was a review by Justin already [1].
> 
> "I read it and have no comments" is somewhere between "an invitation
> to miss" and "it does not highlight anything, either positive or
> negative.  Was the topic that uninteresting and uninspiring without
> anything noteworthy?".

I figured that this might've been it.

> There were mentions of a new document for reviewers, similar to
> SubmittingPatches is for contributors, and it would make a good
> section to document recommended ways for reviewers to demonstrate
> that they understand (1) the area, (2) the goal of the patches, and
> (3) the implementation presented, better.

Right, that's good feedback indeed. Ask questions, reexplain what
happens with your own words to both double check your understanding and
demonstrate it to others, ask for alternative ways to implement
something. These are all ways to ACK a patch series that otherwise looks
good to you already.

Thanks!

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]