Re: [PATCH v3 05/11] reftable/dump: support dumping a table's block structure

[Patrick Steinhardt <ps@pks.im>]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

On Tue, May 21, 2024 at 06:35:13PM -0500, Justin Tobler wrote:
> On 24/05/13 10:18AM, Patrick Steinhardt wrote:
> > +int reftable_reader_print_blocks(const char *tablename)
> > +{
> > +	struct {
> > +		const char *name;
> > +		int type;
> > +	} sections[] = {
> > +		{
> > +			.name = "ref",
> > +			.type = BLOCK_TYPE_REF,
> > +		},
> > +		{
> > +			.name = "obj",
> > +			.type = BLOCK_TYPE_OBJ,
> > +		},
> > +		{
> > +			.name = "log",
> > +			.type = BLOCK_TYPE_LOG,
> > +		},
> > +	};
> 
> I noticed that we are not including all the block types. Would we ever
> want to also be able to dump index blocks? Or would they not be useful
> in this context?

Maybe. It wasn't really necessary to include index blocks in this
context as I was already able to extract all relevant information
without them. So I decided to skip them. We may iterate on this in the
future as required.

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]