git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Telka <marcel@telka.sk>
To: git@vger.kernel.org
Subject: Three t4150 tests does not work as expected
Date: Fri, 17 May 2024 18:45:59 +0200	[thread overview]
Message-ID: <ZkeJx97qdLoaC2H-@telcontar> (raw)

Hi,

I noticed that the following three t4150 tests probably does not work as
expected:

- record as an empty commit when meeting e-mail message that lacks a patch
- record an empty patch as an empty commit in the middle of an am session
- create an non-empty commit when the index IS changed though "--allow-empty" is given

All of them does something like:

	git show HEAD --format="%B" >actual
	grep -f actual expected

While the 'actual' file usually contains something like (four lines
between the 'cut' markers):

-------------------------- cut --------------------------
empty commit

--
2.45.1

-------------------------- cut --------------------------

IOW, there are two empty lines there.  Because of that the grep gets an
empty RE from the 'actual' file and so it matches everything that comes
in the 'expected' file.

Is this the expected behavior?


Thank you.

-- 
+-------------------------------------------+
| Marcel Telka   e-mail:   marcel@telka.sk  |
|                homepage: http://telka.sk/ |
+-------------------------------------------+

             reply	other threads:[~2024-05-17 16:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 16:45 Marcel Telka [this message]
2024-05-17 17:55 ` Three t4150 tests does not work as expected Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZkeJx97qdLoaC2H-@telcontar \
    --to=marcel@telka.sk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).