From: Marcel Telka <marcel@telka.sk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Switch grep from non-portable BRE to portable ERE
Date: Fri, 17 May 2024 20:50:03 +0200 [thread overview]
Message-ID: <Zkem21e_kdVfZsVV@telcontar> (raw)
In-Reply-To: <xmqq7cfsiaff.fsf@gitster.g>
On Fri, May 17, 2024 at 11:02:28AM -0700, Junio C Hamano wrote:
> Thanks for this and other portability patches. You are porting to a
> new platform, I presume, where either nobody else ported to before
> or those who ported did not bother reporting test breakages to us?
Unfortunately, the latter is the case. I'm doing this for OpenIndiana
(an illumos distro, Solaris descendant) and the testing status before I
started the work was:
failed test(s): t0211 t0600 t1404 t1700 t2501 t3404 t4150 t4202 t7609 t9001 t9118 t9210 t9902
fixed 1
success 29241
failed 38
broken 269
total 30158
Now all tests pass.
The work uncovered few bugs in illumos as well. For example, this one
helped to find issues with grep's null RE cases in git tests:
https://www.illumos.org/issues/16561
Thank you.
--
+-------------------------------------------+
| Marcel Telka e-mail: marcel@telka.sk |
| homepage: http://telka.sk/ |
+-------------------------------------------+
next prev parent reply other threads:[~2024-05-17 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 17:10 [PATCH] Switch grep from non-portable BRE to portable ERE Marcel Telka
2024-05-17 18:02 ` Junio C Hamano
2024-05-17 18:50 ` Marcel Telka [this message]
2024-05-17 19:02 ` Marcel Telka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zkem21e_kdVfZsVV@telcontar \
--to=marcel@telka.sk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox