Re: What's cooking in git.git (May 2024, #08; Mon, 20)

[Patrick Steinhardt <ps@pks.im>]

[-- Attachment #1: Type: text/plain, Size: 3686 bytes --]

On Mon, May 20, 2024 at 04:55:26PM -0700, Junio C Hamano wrote:
> * ps/refs-without-the-repository-updates (2024-05-17) 17 commits
>  - refs/packed: remove references to `the_hash_algo`
>  - refs/files: remove references to `the_hash_algo`
>  - refs/files: use correct repository
>  - refs: remove `dwim_log()`
>  - refs: drop `git_default_branch_name()`
>  - refs: pass repo when peeling objects
>  - refs: move object peeling into "object.c"
>  - refs: pass ref store when detecting dangling symrefs
>  - refs: convert iteration over replace refs to accept ref store
>  - refs: retrieve worktree ref stores via associated repository
>  - refs: refactor `resolve_gitlink_ref()` to accept a repository
>  - refs: pass repo when retrieving submodule ref store
>  - refs: track ref stores via strmap
>  - refs: implement releasing ref storages
>  - refs: rename `init_db` callback to avoid confusion
>  - refs: adjust names for `init` and `init_db` callbacks
>  - Merge branch 'ps/refs-without-the-repository' into ps/refs-without-the-repository-updates
> 
>  Further clean-up the refs subsystem to stop relying on
>  the_repository, and instead use the repository associated to the
>  ref_store object.
> 
>  Will merge to 'next'?
>  source: <cover.1715929858.git.ps@pks.im>

We've waited a couple more days now, and there was no additional
feedback so far. I'm happy for this to be merged down.

> * ps/reftable-reusable-iterator (2024-05-13) 13 commits
>  - reftable/merged: adapt interface to allow reuse of iterators
>  - reftable/stack: provide convenience functions to create iterators
>  - reftable/reader: adapt interface to allow reuse of iterators
>  - reftable/generic: adapt interface to allow reuse of iterators
>  - reftable/generic: move seeking of records into the iterator
>  - reftable/merged: simplify indices for subiterators
>  - reftable/merged: split up initialization and seeking of records
>  - reftable/reader: set up the reader when initializing table iterator
>  - reftable/reader: inline `reader_seek_internal()`
>  - reftable/reader: separate concerns of table iter and reftable reader
>  - reftable/reader: unify indexed and linear seeking
>  - reftable/reader: avoid copying index iterator
>  - reftable/block: use `size_t` to track restart point index
> 
>  Code clean-up to make the reftable iterator closer to be reusable.
> 
>  Comments?
>  source: <cover.1715589670.git.ps@pks.im>

There was a round of reviews by Justin on this one, which I've addressed
in v2 and which was acked by him. I'll try to rope in more reviewers
internally to get this over the finish line, but I'd also highly
appreciate any GitLab-external reviews here.

> * ps/reftable-write-options (2024-05-13) 11 commits
>  - refs/reftable: allow configuring geometric factor
>  - reftable: make the compaction factor configurable
>  - refs/reftable: allow disabling writing the object index
>  - refs/reftable: allow configuring restart interval
>  - reftable: use `uint16_t` to track restart interval
>  - refs/reftable: allow configuring block size
>  - reftable/dump: support dumping a table's block structure
>  - reftable/writer: improve error when passed an invalid block size
>  - reftable/writer: drop static variable used to initialize strbuf
>  - reftable: pass opts as constant pointer
>  - reftable: consistently refer to `reftable_write_options` as `opts`
> 
>  The knobs to tweak how reftable files are written have been made
>  available as configuration variables.
> 
>  Comments?
>  source: <cover.1715587849.git.ps@pks.im>

Same here, I'll try to rope in additional reviewers.

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]