git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Arundas T C <arundas.tc@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git pull --ff-only errors when git merge --ff-only passes
Date: Mon, 3 Jun 2024 21:30:21 +0000	[thread overview]
Message-ID: <Zl417UT7n4-FQ2xj@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <CAKRNJbAnUBmR5MHY=uSF1A3docO-uxWG4agWuFZEyPUnduyWHw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]

On 2024-06-03 at 06:28:41, Arundas T C wrote:
> Thank you for filling out a Git bug report!
> Please answer the following questions to help us understand your issue.
> 
> What did you do before the bug happened? (Steps to reproduce your issue)
> 
> 1. In a remote repository, have a commit that's only in remote at the
> tip of the current branch in local.
> 2. In the local clone of this repository, edit some files and have
> unstaged changes.
> 3. In local, run `git pull --ff-only`.
> 
> What did you expect to happen? (Expected behavior)
> 
> Fast-forward the local branch to match the remote branch, similar to
> `git merge --ff-only`. Handle any merge conflicts the same way that
> `git merge --ff-only` does.
> 
> What happened instead? (Actual behavior)
> 
> error: cannot pull with rebase: You have unstaged changes.
> error: Please commit or stash them.

This indicates that you've set pull.rebase, so a `git pull` does a fetch
and a rebase.

> What's different between what you expected and what actually happened?
> 
> It errored out because of unstaged changes, even though doing `git
> merge --ff-only` will correctly do what's expected. See below.
> 
> Anything else you want to add:
> 
> After doing `git fetch`, I can do `git merge --ff-only` and this
> fast-forwards the branch as expected. Isn't `git pull --ff-only`
> basically the same as doing these two (fetch and merge)?

`git merge` doesn't do a rebase.  It does a merge, which can sometimes
be done with a dirty tree.  `git pull` _normally_ does a fetch and a
merge, but in this case, you've asked it to do a fetch and a rebase,
which has different constraints.  The result will almost certainly be
identical (since it's just a fast-forward), but rebases typically don't
allow you to have a dirty working tree.
-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

      parent reply	other threads:[~2024-06-03 21:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-03  6:28 git pull --ff-only errors when git merge --ff-only passes Arundas T C
2024-06-03 15:31 ` Junio C Hamano
2024-06-03 21:30 ` brian m. carlson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zl417UT7n4-FQ2xj@tapette.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=arundas.tc@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).