git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Chandra Pratap <chandrapratap3519@gmail.com>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/2] t: move reftable/basics_test.c to the unit testing framework
Date: Wed, 29 May 2024 08:00:16 +0200	[thread overview]
Message-ID: <ZlbEcHL3fEFXbt-H@tanuki> (raw)
In-Reply-To: <20240528113856.8348-2-chandrapratap3519@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

On Tue, May 28, 2024 at 05:00:02PM +0530, Chandra Pratap wrote:
> --- a/reftable/basics_test.c
> +++ b/t/unit-tests/t-reftable-basics.c
> @@ -1,16 +1,6 @@
> -/*
> -Copyright 2020 Google LLC
> -
> -Use of this source code is governed by a BSD-style
> -license that can be found in the LICENSE file or at
> -https://developers.google.com/open-source/licenses/bsd
> -*/
> -
> -#include "system.h"
> -
> -#include "basics.h"
> -#include "test_framework.h"
> -#include "reftable-tests.h"
> +#include "test-lib.h"
> +#include "reftable/system.h"

There is no need to include "reftable/system.h" explicitly as it is
already transitively included via "reftable/basics.h". The same should
be true for all other reftable headers.

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2024-05-29  6:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 11:30 [GSoC][PATCH] t: port reftable/basics_test.c to the unit testing Chandra Pratap
2024-05-28 11:30 ` [PATCH 1/2] t: move reftable/basics_test.c to the unit testing framework Chandra Pratap
2024-05-28 12:34   ` Christian Couder
2024-05-29  6:00     ` Patrick Steinhardt
2024-05-29  6:00   ` Patrick Steinhardt [this message]
2024-05-28 11:30 ` [PATCH 2/2] t: improve upon reftable/basics_test.c in " Chandra Pratap
2024-05-28 12:46   ` Christian Couder
2024-05-29  6:00     ` Patrick Steinhardt
2024-05-28 12:29 ` [GSoC][PATCH] t: port reftable/basics_test.c to the unit testing Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZlbEcHL3fEFXbt-H@tanuki \
    --to=ps@pks.im \
    --cc=chandrapratap3519@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).