Re: git diff-tree do not honor diff.orderfile config

[Taylor Blau <me@ttaylorr.com>]

On Fri, Jul 05, 2024 at 11:28:23AM +0100, Tiago de Bem Natel de Moura wrote:
> What did you do before the bug happened? (Steps to reproduce your issue)
> The config `diff.orderfile` is not being honored in the `git diff-tree` command
> as stated by the documentation.

Makes sense... the diff.orderFile configuration is part of the "UI" set
of diff.* configuration options, which are honored by porcelain commands
like commit, diff, log, etc., but not by plumbing commands like
diff-tree.

I think from 6d8940b562 (diff: add diff.orderfile configuration
variable, 2013-12-18) adding it to the UI-only configuration set was
intentional, but it is somewhat awkward that we respect -O but not the
configuration it falls back on.

So I suppose the question is whether supporting -O from diff-tree is
sensible. If it is, then reading the diff.orderFile configuration option
is a no-brainer. But if it isn't, then we should probably not make a bad
situation worse by adding support for it.

Thanks,
Taylor