git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>,
	"Taylor Blau" <me@ttaylorr.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3] Documentation: add platform support policy
Date: Tue, 23 Jul 2024 11:02:01 +0200	[thread overview]
Message-ID: <Zp9xiYVh11KurICO@tanuki> (raw)
In-Reply-To: <20240718173843.2411415-1-emilyshaffer@google.com>

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On Thu, Jul 18, 2024 at 10:38:43AM -0700, Emily Shaffer wrote:
> +* If you rely on Git avoiding a specific pattern that doesn't work well with
> +  your platform (like a certain malloc pattern), raise it on the mailing list.
> +  There are a few ways to avoid these breakages, so we'll work case-by-case to
> +  find a solution that doesn't unnecessarily constrain other platforms to keep
> +  compatibility with yours.

I found the latter part of this bullet point a bit weird. We don't yet
know about the specific pattern that may fail on any future supported
platform, so claiming that there are ways to avoid them goes a bit too
far, no?

> +** Include a comment with an expiration date for these tests no more than 1 year
> +   from now. You can update the expiration date if your platform still needs
> +   that assurance down the road, but we need to know you still care about that
> +   compatibility case and are working to make it unnecessary.

Do we maybe want to replace "from now" with "from when you add them"?

Other than that this document looks great to me, thanks!

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2024-07-23  9:02 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 22:50 [PATCH] Documentation: add platform support policy Emily Shaffer
2024-07-09 23:16 ` brian m. carlson
2024-07-11 18:14   ` Emily Shaffer
2024-07-11 20:12     ` Kyle Lippincott
2024-07-11 20:24       ` rsbecker
2024-07-11 20:57       ` Emily Shaffer
2024-07-11 22:24     ` brian m. carlson
2024-07-11 23:15       ` Emily Shaffer
2024-07-12 19:33         ` brian m. carlson
2024-07-12 19:46           ` rsbecker
2024-07-15 22:28             ` Emily Shaffer
2024-07-15 22:50               ` rsbecker
2024-07-15 22:23           ` Emily Shaffer
2024-07-10  0:57 ` Junio C Hamano
2024-07-10 18:55   ` Emily Shaffer
2024-07-10 20:13     ` Junio C Hamano
2024-07-11 18:26       ` Emily Shaffer
2024-07-10 20:20     ` rsbecker
2024-07-11 18:19       ` Emily Shaffer
2024-07-11 18:53         ` rsbecker
2024-07-10 19:11 ` Kyle Lippincott
2024-07-11 18:37   ` Emily Shaffer
2024-07-11 19:36     ` Junio C Hamano
2024-07-11 19:55       ` Junio C Hamano
2024-07-11 20:25     ` Kyle Lippincott
2024-07-11 23:24 ` [PATCH v2] " Emily Shaffer
2024-07-12 18:15   ` Junio C Hamano
2024-07-15 22:20     ` Emily Shaffer
2024-07-15 23:46       ` Junio C Hamano
2024-07-16 17:58         ` Emily Shaffer
2024-07-16 18:20           ` rsbecker
2024-07-17 18:16           ` Junio C Hamano
2024-07-18 17:38   ` [PATCH v3] " Emily Shaffer
2024-07-18 18:22     ` Emily Shaffer
2024-07-18 21:47       ` Junio C Hamano
2024-07-18 22:46     ` Junio C Hamano
2024-07-18 23:45       ` rsbecker
2024-07-25 16:53         ` Emily Shaffer
2024-07-25 18:52       ` Emily Shaffer
2024-07-25 19:34         ` Junio C Hamano
2024-07-25 19:40         ` rsbecker
2024-07-23  9:02     ` Patrick Steinhardt [this message]
2024-07-25 20:27       ` Emily Shaffer
2024-07-23 21:49     ` Josh Steadmon
2024-07-25 20:31       ` Emily Shaffer
2024-07-30 17:54     ` [PATCH v4] " Emily Shaffer
2024-07-30 19:26       ` Junio C Hamano
2024-07-30 20:41         ` Emily Shaffer
2024-07-30 21:24           ` Junio C Hamano
2024-07-30 22:40             ` rsbecker
2024-07-31 17:20               ` Emily Shaffer
2024-07-31 20:58                 ` rsbecker
2024-08-02 22:19       ` [PATCH v5] " Emily Shaffer
2024-08-02 23:31         ` Junio C Hamano
2024-08-02 23:32           ` rsbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zp9xiYVh11KurICO@tanuki \
    --to=ps@pks.im \
    --cc=avarab@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=me@ttaylorr.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).