From: Taylor Blau <me@ttaylorr.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] log-tree: use decimal_width()
Date: Sun, 4 Aug 2024 12:10:57 -0400 [thread overview]
Message-ID: <Zq+oEby6ew3HrWFK@nand.local> (raw)
In-Reply-To: <06783722-5184-41d5-8edd-94f97b2f2794@web.de>
On Sat, Aug 03, 2024 at 02:33:24PM +0200, René Scharfe wrote:
> ---
> log-tree.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
This looks all very reasonable to me.
Some history (if interesting): lineno_width(), which was the precursor
to decimal_width() was introduced way back in cee7f245dc (git-pickaxe:
blame rewritten., 2006-10-19). The piece this patch removes was added in
e00de24b10 (format-patch -n: make sorting easier by padding number,
2007-02-09), but lineno_width() did not become part of pager.h until
ec7ff5ba27 (make lineno_width() from blame reusable for others,
2012-02-12), hence why it wasn't already used here.
Thanks,
Taylor
next prev parent reply other threads:[~2024-08-04 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-03 12:33 [PATCH] log-tree: use decimal_width() René Scharfe
2024-08-04 16:10 ` Taylor Blau [this message]
2024-08-05 16:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zq+oEby6ew3HrWFK@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).