From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/5] refs/packed: stop using `the_repository`
Date: Wed, 31 Jul 2024 06:59:39 +0200 [thread overview]
Message-ID: <ZqnEuz9uFgUwWKkc@tanuki> (raw)
In-Reply-To: <CAOLa=ZQqh7x9xaZXenRoMM8+fE+c5jOG73J5hPg-q=b_s+vxXQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
On Tue, Jul 30, 2024 at 07:23:55AM -0400, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > Convert the packed ref backend to stop using `the_repository` in favor
> > of the repo that gets passed in via `struct ref_store`.
> >
>
> Nit: Might be nice to add that we move to using `get_oid_hex_algop` in
> this commit. Since it was also mentioned in a prev commit
Yeah, that'd make sense indeed. I'll refrain from sending out a new
version of this patch series just to amend the commit message, but have
queued the change locally and will send it out in case any other changes
are required for this patch series.
Thanks!
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-07-31 4:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 5:22 [PATCH 0/5] refs: stop using `the_repository` Patrick Steinhardt
2024-07-30 5:22 ` [PATCH 1/5] " Patrick Steinhardt
2024-07-30 5:22 ` [PATCH 2/5] refs/files: stop using `the_repository` in `parse_loose_ref_contents()` Patrick Steinhardt
2024-07-30 5:22 ` [PATCH 3/5] refs/files: stop using `the_repository` Patrick Steinhardt
2024-07-30 5:23 ` [PATCH 4/5] refs/packed: " Patrick Steinhardt
2024-07-30 11:23 ` Karthik Nayak
2024-07-31 4:59 ` Patrick Steinhardt [this message]
2024-07-30 5:23 ` [PATCH 5/5] refs/reftable: " Patrick Steinhardt
2024-07-30 11:26 ` [PATCH 0/5] refs: " Karthik Nayak
2024-07-31 5:01 ` Patrick Steinhardt
2024-07-31 0:55 ` James Liu
2024-07-31 5:06 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqnEuz9uFgUwWKkc@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).