From: Patrick Steinhardt <ps@pks.im>
To: "Rubén Justo" <rjusto@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 07/23] builtin/submodule--helper: fix various trivial memory leaks
Date: Thu, 1 Aug 2024 10:20:01 +0200 [thread overview]
Message-ID: <ZqtFMYEGuKRu1amZ@tanuki> (raw)
In-Reply-To: <82f4bef1-57d9-4427-8316-5e63b573931d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Wed, Jul 31, 2024 at 11:52:26PM +0200, Rubén Justo wrote:
> On Fri, Jul 26, 2024 at 02:15:09PM +0200, Patrick Steinhardt wrote:
>
> > There are multiple trivial memory leaks in the submodule helper. Fix
> > those.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
>
> Hi Patrick,
>
> While working on another series, I fixed some leaks. But, I haven't
> sent any patches.
>
> The series this message belongs to fixes all the leaks that my unsent
> series addresses. So, I won't bother sending my patches.
>
> However, I think we can do better for the second leak solved in this
> patch. I leave my patch at the end of this message in case you want
> to take a look.
Agreed, your patch looks way neater. I'll massage the patch a bit and
then add it to the series with an "Original-patch-by" trailer.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-08-01 8:20 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 12:13 [PATCH 00/23] Memory leak fixes (pt.3) Patrick Steinhardt
2024-07-26 12:13 ` [PATCH 01/23] builtin/replay: plug leaking `advance_name` variable Patrick Steinhardt
2024-07-31 16:22 ` Taylor Blau
2024-07-26 12:14 ` [PATCH 02/23] builtin/log: fix leaking branch name when creating cover letters Patrick Steinhardt
2024-07-30 9:14 ` Karthik Nayak
2024-07-31 16:23 ` Taylor Blau
2024-07-26 12:14 ` [PATCH 03/23] builtin/describe: fix memory leak with `--contains=` Patrick Steinhardt
2024-07-30 9:23 ` Karthik Nayak
2024-07-30 15:27 ` Junio C Hamano
2024-07-31 10:42 ` Patrick Steinhardt
2024-07-31 16:04 ` Junio C Hamano
2024-07-31 16:28 ` Taylor Blau
2024-07-26 12:14 ` [PATCH 04/23] builtin/describe: fix leaking array when running diff-index Patrick Steinhardt
2024-07-30 9:34 ` Karthik Nayak
2024-07-26 12:14 ` [PATCH 05/23] builtin/describe: fix trivial memory leak when describing blob Patrick Steinhardt
2024-07-26 12:14 ` [PATCH 06/23] builtin/name-rev: fix various trivial memory leaks Patrick Steinhardt
2024-07-30 15:36 ` Junio C Hamano
2024-07-26 12:15 ` [PATCH 07/23] builtin/submodule--helper: " Patrick Steinhardt
2024-07-31 21:52 ` Rubén Justo
2024-08-01 8:20 ` Patrick Steinhardt [this message]
2024-07-26 12:15 ` [PATCH 08/23] builtin/ls-remote: fix leaking `pattern` strings Patrick Steinhardt
2024-07-31 16:35 ` Taylor Blau
2024-08-01 8:19 ` Patrick Steinhardt
2024-07-26 12:15 ` [PATCH 09/23] builtin/remote: fix leaking strings in `branch_list` Patrick Steinhardt
2024-07-31 16:37 ` Taylor Blau
2024-07-26 12:15 ` [PATCH 10/23] builtin/remote: fix various trivial memory leaks Patrick Steinhardt
2024-07-26 12:16 ` [PATCH 11/23] builtin/stash: " Patrick Steinhardt
2024-07-31 16:40 ` Taylor Blau
2024-07-26 12:16 ` [PATCH 12/23] builtin/rev-parse: fix memory leak with `--parseopt` Patrick Steinhardt
2024-07-30 11:00 ` Karthik Nayak
2024-07-26 12:16 ` [PATCH 13/23] builtin/show-branch: fix several memory leaks Patrick Steinhardt
2024-07-26 12:17 ` [PATCH 14/23] builtin/credential-store: fix leaking credential Patrick Steinhardt
2024-07-26 12:17 ` [PATCH 15/23] builtin/rerere: fix various trivial memory leaks Patrick Steinhardt
2024-07-26 12:17 ` [PATCH 16/23] builtin/shortlog: " Patrick Steinhardt
2024-07-26 12:17 ` [PATCH 17/23] builtin/worktree: fix leaking derived branch names Patrick Steinhardt
2024-07-26 12:17 ` [PATCH 18/23] builtin/credential-cache: fix trivial leaks Patrick Steinhardt
2024-07-26 12:18 ` [PATCH 19/23] t/test-repository: fix leaking repository Patrick Steinhardt
2024-07-26 12:18 ` [PATCH 20/23] object-name: fix leaking commit list items Patrick Steinhardt
2024-07-26 12:18 ` [PATCH 21/23] entry: fix leaking pathnames during delayed checkout Patrick Steinhardt
2024-07-26 12:19 ` [PATCH 22/23] convert: fix leaking config strings Patrick Steinhardt
2024-07-26 12:19 ` [PATCH 23/23] commit-reach: fix trivial memory leak when computing reachability Patrick Steinhardt
2024-07-30 11:09 ` [PATCH 00/23] Memory leak fixes (pt.3) Karthik Nayak
2024-07-31 10:44 ` Patrick Steinhardt
2024-07-31 17:01 ` Taylor Blau
2024-08-01 8:19 ` Patrick Steinhardt
2024-08-01 17:16 ` Taylor Blau
2024-08-01 10:38 ` [PATCH v2 00/24] " Patrick Steinhardt
2024-08-01 10:38 ` [PATCH v2 01/24] builtin/replay: plug leaking `advance_name` variable Patrick Steinhardt
2024-08-01 10:38 ` [PATCH v2 02/24] builtin/log: fix leaking branch name when creating cover letters Patrick Steinhardt
2024-08-01 10:38 ` [PATCH v2 03/24] builtin/describe: fix memory leak with `--contains=` Patrick Steinhardt
2024-08-01 10:38 ` [PATCH v2 04/24] builtin/describe: fix leaking array when running diff-index Patrick Steinhardt
2024-08-01 10:38 ` [PATCH v2 05/24] builtin/describe: fix trivial memory leak when describing blob Patrick Steinhardt
2024-08-01 10:38 ` [PATCH v2 06/24] builtin/name-rev: fix various trivial memory leaks Patrick Steinhardt
2024-08-01 10:39 ` [PATCH v2 08/24] builtin/submodule--helper: fix leaking buffer in `is_tip_reachable` Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 09/24] builtin/ls-remote: fix leaking `pattern` strings Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 10/24] builtin/remote: fix leaking strings in `branch_list` Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 11/24] builtin/remote: fix various trivial memory leaks Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 12/24] builtin/stash: " Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 13/24] builtin/rev-parse: fix memory leak with `--parseopt` Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 14/24] builtin/show-branch: fix several memory leaks Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 15/24] builtin/credential-store: fix leaking credential Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 16/24] builtin/rerere: fix various trivial memory leaks Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 17/24] builtin/shortlog: " Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 18/24] builtin/worktree: fix leaking derived branch names Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 19/24] builtin/credential-cache: fix trivial leaks Patrick Steinhardt
2024-08-01 10:40 ` [PATCH v2 20/24] t/test-repository: fix leaking repository Patrick Steinhardt
2024-08-01 10:41 ` [PATCH v2 21/24] object-name: fix leaking commit list items Patrick Steinhardt
2024-08-01 10:41 ` [PATCH v2 22/24] entry: fix leaking pathnames during delayed checkout Patrick Steinhardt
2024-08-01 10:41 ` [PATCH v2 23/24] convert: fix leaking config strings Patrick Steinhardt
2024-08-01 10:41 ` [PATCH v2 24/24] commit-reach: fix trivial memory leak when computing reachability Patrick Steinhardt
2024-08-01 10:42 ` [PATCH v2 07/24] builtin/submodule--helper: fix leaking clone depth parameter Patrick Steinhardt
2024-08-01 17:17 ` [PATCH v2 00/24] Memory leak fixes (pt.3) Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqtFMYEGuKRu1amZ@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).