Re: [PATCH v4 0/7] Introduce clar testing framework

[Patrick Steinhardt <ps@pks.im>]

On Thu, Aug 15, 2024 at 09:21:04AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Hi,
> >
> > this is the fourth version of my patch series that introduces the clar
> > testing framework for our unit tests.
> >
> > Changes compared to v3:
> >
> >   - Seeing that the overall feedback seems to be rather positive, I've
> >     now dropped the "RFC" prefix.
> >
> >   - Fix another whitespace-damaged line in the clar unit test. I've
> >     adapted the upstream pull request accordingly.
> >
> >   - Fix `make hdr-check`, which failed due to the missing dependency on
> >     "clar-decls.h".
> 
> Similarly, lack of clar.suite still makes "make sparse" fail, it
> seems.
> 
> $ make NO_REGEX=NoThanks -j32 sparse
>     ...
>     SP builtin/help.c
>     CC t/unit-tests/ctype.o
>     CC t/unit-tests/strvec.o
>     CC t/unit-tests/clar/clar.o
>     CC t/unit-tests/unit-test.o
> t/unit-tests/clar/clar.c:209:10: fatal error: clar.suite: No such file or directory
>   209 | #include "clar.suite"
>       |          ^~~~~~~~~~~~
> compilation terminated.
> make: *** [Makefile:2762: t/unit-tests/clar/clar.o] Error 1
> make: *** Waiting for unfinished jobs....
> 
> The NO_REGEX is there to force us to go check the compat/regex.h as well.

Huh, OK. Wonder why the CI didn't catch this. I'll have another look,
thanks.

Patrick