From: Patrick Steinhardt <ps@pks.im>
To: Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org, Sebastian Schuberth <sschuberth@gmail.com>
Subject: Re: [PATCH 3/5] setup: merge configuration of repository formats
Date: Fri, 16 Aug 2024 10:06:56 +0200 [thread overview]
Message-ID: <Zr8IoDy9dU2MNVB-@tanuki> (raw)
In-Reply-To: <hxnibmbakpvh72kfrycxnvo5a24f6atcqa73yys4zthbqpwikq@s7435n3nqmlz>
On Thu, Aug 15, 2024 at 04:37:26PM -0500, Justin Tobler wrote:
> On 24/08/15 10:00AM, Patrick Steinhardt wrote:
> > - repo_set_hash_algo(the_repository, repo_fmt.hash_algo);
> > - repo_set_ref_storage_format(the_repository, repo_fmt.ref_storage_format);
> > + repository_format_configure(&repo_fmt, hash, ref_storage_format);
>
> Overall, I like that this repostory format configuration is under
> `repository_format_configure()`. The `validate_*()` functions names
> confused me slightly initially because I assumed they were only
> validating, but they also configure the repo format. Looking good :)
Yeah, agreed. We _did_ validate whether the new configuration makes
sense, but that wasn't really the main thing those functions did.
Patrick
next prev parent reply other threads:[~2024-08-16 8:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 7:59 [PATCH 0/5] Introduce configs for default repo format Patrick Steinhardt
2024-08-15 7:59 ` [PATCH 1/5] t0001: exercise initialization with ref formats more thoroughly Patrick Steinhardt
2024-08-15 20:35 ` Justin Tobler
2024-08-15 8:00 ` [PATCH 2/5] t0001: delete repositories when object format tests finish Patrick Steinhardt
2024-08-15 8:00 ` [PATCH 3/5] setup: merge configuration of repository formats Patrick Steinhardt
2024-08-15 21:37 ` Justin Tobler
2024-08-16 8:06 ` Patrick Steinhardt [this message]
2024-08-15 8:00 ` [PATCH 4/5] setup: make object format configurable via config Patrick Steinhardt
2024-08-15 22:17 ` Justin Tobler
2024-08-15 8:00 ` [PATCH 5/5] setup: make ref storage " Patrick Steinhardt
2024-08-15 22:29 ` Justin Tobler
2024-08-15 15:24 ` [PATCH 0/5] Introduce configs for default repo format shejialuo
2024-08-15 21:16 ` brian m. carlson
2024-08-15 21:52 ` Junio C Hamano
2024-08-16 8:07 ` Patrick Steinhardt
2024-08-15 21:22 ` brian m. carlson
2024-08-16 8:56 ` [PATCH v2 " Patrick Steinhardt
2024-08-16 8:56 ` [PATCH v2 1/5] t0001: exercise initialization with ref formats more thoroughly Patrick Steinhardt
2024-08-16 8:56 ` [PATCH v2 2/5] t0001: delete repositories when object format tests finish Patrick Steinhardt
2024-08-16 8:56 ` [PATCH v2 3/5] setup: merge configuration of repository formats Patrick Steinhardt
2024-08-16 8:57 ` [PATCH v2 4/5] setup: make object format configurable via config Patrick Steinhardt
2024-08-16 17:13 ` Junio C Hamano
2024-08-16 8:57 ` [PATCH v2 5/5] setup: make ref storage " Patrick Steinhardt
2024-08-16 14:46 ` [PATCH v2 0/5] Introduce configs for default repo format Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr8IoDy9dU2MNVB-@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).