From: Patrick Steinhardt <ps@pks.im>
To: Han Young <hanyang.tony@bytedance.com>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] doc: pack-objects: clarify --missing option
Date: Thu, 8 Aug 2024 09:48:41 +0200 [thread overview]
Message-ID: <ZrR4WVtSs5deJCPu@tanuki> (raw)
In-Reply-To: <20240808062120.34629-1-hanyang.tony@bytedance.com>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On Thu, Aug 08, 2024 at 02:21:20PM +0800, Han Young wrote:
> Since ee47243d76 (pack-objects: no fetch when allow-{any,promisor},
> 2020-08-05), we mention that --missing=allow-any and --missing=allow-promisor
> do not fetch missing objects. But this is only true for missing objects
> that are discovered during object traversal. We will still fetch
> missing objects read from stdin.
I have to wonder whether this is intentional or a bug. It rather feels
like the latter to me. Let me Cc Chris, who has written most of the
infra of this feature.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-08-08 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 6:21 [PATCH] doc: pack-objects: clarify --missing option Han Young
2024-08-08 7:48 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrR4WVtSs5deJCPu@tanuki \
--to=ps@pks.im \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=hanyang.tony@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox