git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/8] pseudo-merge: avoid empty and non-closed pseudo-merge commits
Date: Thu, 29 Aug 2024 15:04:02 -0400	[thread overview]
Message-ID: <ZtDGImCRmC0N/cen@nand.local> (raw)
In-Reply-To: <20240817104412.GE551779@coredump.intra.peff.net>

On Sat, Aug 17, 2024 at 06:44:12AM -0400, Jeff King wrote:
> On Thu, Aug 15, 2024 at 01:30:56PM -0400, Taylor Blau wrote:
>
> > This series fixes a couple of small issues with pseudo-merge groups,
> > where it is possible to (a) select pseudo-merges that are not closed
> > over reachability with respect to the bitmap's pack or MIDX, and (b)
> > generate empty pseudo-merge commits.
>
> Thanks, the whole series looks good to me (I left some comments, but it
> is all just walking through my thought process).

Thanks (as always) for a thoughtful review!

Thanks,
Taylor

      reply	other threads:[~2024-08-29 19:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 17:30 [PATCH 0/8] pseudo-merge: avoid empty and non-closed pseudo-merge commits Taylor Blau
2024-08-15 17:31 ` [PATCH 1/8] pack-bitmap: initialize `bitmap_writer_init()` with packing_data Taylor Blau
2024-08-17 10:31   ` Jeff King
2024-08-29 19:00     ` Taylor Blau
2024-08-29 19:36       ` Jeff King
2024-08-15 17:31 ` [PATCH 2/8] pack-bitmap: drop redundant args from `bitmap_writer_build_type_index()` Taylor Blau
2024-08-15 17:31 ` [PATCH 3/8] pack-bitmap: drop redundant args from `bitmap_writer_build()` Taylor Blau
2024-08-15 17:31 ` [PATCH 4/8] pack-bitmap: drop redundant args from `bitmap_writer_finish()` Taylor Blau
2024-08-15 17:31 ` [PATCH 5/8] pack-bitmap-write.c: select pseudo-merges even for small bitmaps Taylor Blau
2024-08-17 10:34   ` Jeff King
2024-08-17 16:42     ` Junio C Hamano
2024-08-29 19:01     ` Taylor Blau
2024-08-15 17:31 ` [PATCH 6/8] t/t5333-pseudo-merge-bitmaps.sh: demonstrate empty pseudo-merge groups Taylor Blau
2024-08-15 17:31 ` [PATCH 7/8] pseudo-merge.c: do not generate empty pseudo-merge commits Taylor Blau
2024-08-17 10:38   ` Jeff King
2024-08-29 19:03     ` Taylor Blau
2024-08-15 17:31 ` [PATCH 8/8] pseudo-merge.c: ensure pseudo-merge groups are closed Taylor Blau
2024-08-17 10:43   ` Jeff King
2024-08-17 10:44 ` [PATCH 0/8] pseudo-merge: avoid empty and non-closed pseudo-merge commits Jeff King
2024-08-29 19:04   ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtDGImCRmC0N/cen@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).