git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Xing Xin <bupt_xingxin@163.com>
Cc: Xing Xin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Brandon Williams <bmwill@google.com>,
	Jonathan Tan <jonathantanmy@google.com>,
	Xing Xin <xingxin.xx@bytedance.com>
Subject: Re: Re: Re: [PATCH 3/4] builtin/clone.c: recognize fetch.serverOption configuration
Date: Thu, 5 Sep 2024 15:44:41 +0200	[thread overview]
Message-ID: <Ztm1w_61vjEkiC4C@pks.im> (raw)
In-Reply-To: <3ce04aef.b004.191c21a2159.Coremail.bupt_xingxin@163.com>

On Thu, Sep 05, 2024 at 08:12:58PM +0800, Xing Xin wrote:
> At 2024-09-05 19:05:15, "Patrick Steinhardt" <ps@pks.im> wrote:
> >On Wed, Sep 04, 2024 at 03:49:28PM +0800, Xing Xin wrote:
> >> At 2024-09-03 18:09:45, "Patrick Steinhardt" <ps@pks.im> wrote:
> >> >In the latter case I could see that it may make sense to instead make
> >> >this `remote.<name>.serverOption`. This would also remove the unclean
> >> 
> >> I named the new configuration `fetch.serverOption` mainly to follow the
> >> `push.pushOption` pattern.  Since which server options to support is
> >> actually server-specific, using `remote.<name>.serverOption` is a good
> >> idea for git-fetch. However, how should we design the configuration for
> >> git-ls-remote or git-clone, if we wanna provide all of them with a
> >> default list of server options to send?
> >
> >As mentioned in another reply, I think that putting this into the remote
> >configuration "remote.*.serverOption" might be a better solution, as it
> >also brings you the ability to set this per remote by default.
> 
> I agree that using "remote.*.serverOption" is better. In fact, I also
> think "push.pushOption" would be better as "remote.*.pushOption". What I'm
> contemplating is whether we need to add a configuration for a default
> list of server options, so that when "remote.origin.serverOption" is not
> present, we can fall back to use that as default.

Junio proposed in [1] to introduce `[remote "*"]` syntax to supply
default values to all remotes. You could pick up that proposal and
implement it as part of your patch series.

I also have to agree that "push.pushOption" would be way more sensible
if it was configured per remote. I think it would be sensible to also
introduce "remote.*.pushOption" in the same way and have it override the
default value of "push.pushOption" if present. So the precedence order
would become (from high to low):

  - remote.someRemote.pushOption
  - remote."*".pushOption
  - push.PushOption

This should be backwards compatible, too.

Patrick

[1]: <xmqq5xrcn2k1.fsf@gitster.g>

  reply	other threads:[~2024-09-05 13:44 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02 12:13 [PATCH 0/4] Support server option from configuration blanet via GitGitGadget
2024-09-02 12:13 ` [PATCH 1/4] transport: add parse_transport_option() method Xing Xin via GitGitGadget
2024-09-02 12:13 ` [PATCH 2/4] builtin/fetch.c: add fetch.serverOption configuration Xing Xin via GitGitGadget
2024-09-03 10:09   ` Patrick Steinhardt
2024-09-02 12:13 ` [PATCH 3/4] builtin/clone.c: recognize " Xing Xin via GitGitGadget
2024-09-03 10:09   ` Patrick Steinhardt
2024-09-04  7:49     ` Xing Xin
2024-09-05 11:05       ` Patrick Steinhardt
2024-09-05 12:12         ` Xing Xin
2024-09-05 13:44           ` Patrick Steinhardt [this message]
2024-09-05 17:50             ` Junio C Hamano
2024-09-09  2:50             ` Re:Re: Re: " Xing Xin
2024-09-09 11:49               ` Patrick Steinhardt
2024-09-23 13:04                 ` Xing Xin
2024-09-09 15:44               ` Junio C Hamano
2024-09-02 12:13 ` [PATCH 4/4] builtin/ls-remote.c: " Xing Xin via GitGitGadget
2024-09-03 10:09   ` Patrick Steinhardt
2024-09-03 10:09 ` [PATCH 0/4] Support server option from configuration Patrick Steinhardt
2024-09-23 12:17 ` [PATCH v2 0/5] " blanet via GitGitGadget
2024-09-23 12:17   ` [PATCH v2 1/5] transport: introduce parse_transport_option() method Xing Xin via GitGitGadget
2024-09-23 12:17   ` [PATCH v2 2/5] remote: introduce remote.<name>.serverOption configuration Xing Xin via GitGitGadget
2024-10-07  8:22     ` Patrick Steinhardt
2024-10-08  3:38       ` Xing Xin
2024-09-23 12:17   ` [PATCH v2 3/5] transport.c::handshake: make use of server options from remote Xing Xin via GitGitGadget
2024-09-23 12:17   ` [PATCH v2 4/5] fetch: respect --server-option when fetching multiple remotes Xing Xin via GitGitGadget
2024-10-07  8:22     ` Patrick Steinhardt
2024-09-23 12:17   ` [PATCH v2 5/5] ls-remote: leakfix for not clearing server_options Xing Xin via GitGitGadget
2024-10-07  8:22     ` Patrick Steinhardt
2024-10-07  8:23   ` [PATCH v2 0/5] Support server option from configuration Patrick Steinhardt
2024-10-08  3:42     ` Xing Xin
2024-10-08  3:38   ` [PATCH v3 " blanet via GitGitGadget
2024-10-08  3:38     ` [PATCH v3 1/5] transport: introduce parse_transport_option() method Xing Xin via GitGitGadget
2024-10-08  3:38     ` [PATCH v3 2/5] remote: introduce remote.<name>.serverOption configuration Xing Xin via GitGitGadget
2024-10-08  3:38     ` [PATCH v3 3/5] transport.c::handshake: make use of server options from remote Xing Xin via GitGitGadget
2024-10-08  3:38     ` [PATCH v3 4/5] fetch: respect --server-option when fetching multiple remotes Xing Xin via GitGitGadget
2024-10-08 17:57       ` Junio C Hamano
2024-10-08  3:38     ` [PATCH v3 5/5] ls-remote: leakfix for not clearing server_options Xing Xin via GitGitGadget
2024-10-08  4:00     ` [PATCH v3 0/5] Support server option from configuration Patrick Steinhardt
2024-10-08 17:23       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ztm1w_61vjEkiC4C@pks.im \
    --to=ps@pks.im \
    --cc=bmwill@google.com \
    --cc=bupt_xingxin@163.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jonathantanmy@google.com \
    --cc=xingxin.xx@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).