From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 0/3] sparse-checkout file handle leak fix
Date: Fri, 6 Sep 2024 11:25:24 +0200 [thread overview]
Message-ID: <ZtrKf4CW_vxJt9eA@pks.im> (raw)
In-Reply-To: <20240906034557.GA3693911@coredump.intra.peff.net>
On Thu, Sep 05, 2024 at 11:45:57PM -0400, Jeff King wrote:
> Here's a re-roll that fixes the use-after-free of the lock filename that
> Patrick noticed. I pulled the error-checking fix into its own patch
> (patch 2 here), and did Junio's suggested "goto out" as preparation in
> patch 1. Patch 3 is the leak fix.
>
> Range diff is below, but it's much harder to read than just looking at
> the updated patch 3.
>
> Thanks both for review on round 1.
Thanks for going the extra steps! This version looks good to me.
Patrick
prev parent reply other threads:[~2024-09-06 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 8:27 [PATCH] sparse-checkout: use fdopen_lock_file() instead of xfdopen() Jeff King
2024-09-05 10:54 ` Patrick Steinhardt
2024-09-05 21:16 ` Junio C Hamano
2024-09-05 21:20 ` Junio C Hamano
2024-09-06 1:19 ` Jeff King
2024-09-06 14:55 ` Junio C Hamano
2024-09-05 15:16 ` Junio C Hamano
2024-09-06 3:45 ` [PATCH v2 0/3] sparse-checkout file handle leak fix Jeff King
2024-09-06 3:47 ` [PATCH v2 1/3] sparse-checkout: consolidate cleanup when writing patterns Jeff King
2024-09-06 3:47 ` [PATCH v2 2/3] sparse-checkout: check commit_lock_file " Jeff King
2024-09-06 3:48 ` [PATCH v2 3/3] sparse-checkout: use fdopen_lock_file() instead of xfdopen() Jeff King
2024-09-06 9:25 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtrKf4CW_vxJt9eA@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).