git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Marcos Del Sol Vives <marcos@orca.pet>
Cc: Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: Permission issue in Git in DrvFs-mounted network drives
Date: Fri, 20 Sep 2024 20:43:31 +0000	[thread overview]
Message-ID: <Zu3ec1mDj9JD1Bbj@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <19210b887c6.f59622352625372.1022723129771458212@orca.pet>

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

On 2024-09-20 at 18:36:21, Marcos Del Sol Vives wrote:
> ---- El Fri, 20 Sep 2024 17:51:57 +0200,  brian m. carlson  escribió ----
> > Other folks may feel differently about fixing this, but I would suggest
> > against it.
> 
> I understand that it's a workaround required due to non-POSIX compliance,
> but considering it should have no impact on any other OS and will actually
> as you said make buggy NFS mount work, IMHO it'd be still nice to have
> the changes made.

Git could, in theory, accept a patch here.  However, you're also going
to have lots of other software that breaks in this case, not just Git.
So it's less useful to patch Git and hundreds of other packages on Linux
distributions that have relied on the POSIX standard and more useful to
fix your OS (or maybe switch to WSL2, if that doesn't have the problem).
Most Linux distros will generally not be interested in fixing this class
of problem, in my experience.

In addition, chmod doesn't always work under WSL.  I believe it _does_
work if the drive is mounted with metadata, but some people don't have
that enabled and I don't know if it works for all drives.  For those
people, the current code will work, since it doesn't call chmod or
fchmod, but it will fail with your patch.
-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2024-09-20 20:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 16:16 Permission issue in Git in DrvFs-mounted network drives Marcos Del Sol Vives
2024-09-18 16:30 ` rsbecker
2024-09-18 16:38   ` Marcos Del Sol Vives
2024-09-20 15:51 ` brian m. carlson
2024-09-20 18:15   ` Junio C Hamano
2024-09-20 18:36     ` Marcos Del Sol Vives
2024-09-20 20:43       ` brian m. carlson [this message]
2024-09-20 22:39         ` Marcos Del Sol Vives
2024-09-21 11:20           ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zu3ec1mDj9JD1Bbj@tapette.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=marcos@orca.pet \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).