Re: [PATCH 5/4] ci: add Ubuntu 16.04 job to GitLab CI

[Patrick Steinhardt <ps@pks.im>]

On Fri, Sep 13, 2024 at 02:43:52AM -0400, Jeff King wrote:
> On Fri, Sep 13, 2024 at 08:39:34AM +0200, Patrick Steinhardt wrote:
> 
> > > OK, this looks reasonable to me. I do think we could have our cake and
> > > eat it too on the Apache support if we added a GIT_TEST_HTTP2 knob. But
> > > it's probably not all that big a deal in practice, and after another 1.5
> > > years I think we'd drop this 16.04 job anyway (since it will be out of
> > > LTS then).
> > 
> > Note that we _do_ run the Apache tests, but only for HTTP/1. That's what
> > the "auto" setting does automatically: Apache starts up just fine
> > without the HTTP/2 module and thus we run all tests that don't rely on
> > HTTP/2. On the other hand it fails to boot with HTTP/2, and thus we skip
> > over these tests automatically.
> 
> Right, what I mean is that we would not notice if that job started
> skipping the HTTP/1 tests (e.g., because we changed something in
> apache.conf that didn't work on that old distro). We know it works now,
> but our ideal config going forward is "skip the HTTP/2 tests if needed,
> but fail if the HTTP/1 tests do not run".

Ah, that's true indeed. As you mention it probably doesn't matter all
that much. I think it's nice to verify that things work to the best
extent possible for such old platforms. But wiring up a new prereq just
for that doesn't feel all that important to me.

Patrick